Fix: Don't report setter params in class bodies as unused (fixes #7351)…

… (#7352)
eslint · Oct 14, 2016 · 2729d94 · 2729d94
1 parent 0b85004
commit 2729d94
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -494,7 +494,7 @@ module.exports = {
                         if (type === "Parameter") {
 
                             // skip any setter argument
-                            if (def.node.parent.type === "Property" && def.node.parent.kind === "set") {
+                            if ((def.node.parent.type === "Property" || def.node.parent.type === "MethodDefinition") && def.node.parent.kind === "set") {
                                 continue;
                             }
 

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
@@ -256,6 +256,16 @@ ruleTester.run("no-unused-vars", rule, {
             options: [{argsIgnorePattern: "[cd]"}],
             parserOptions: {ecmaVersion: 6},
         },
+
+        // https://github.com/eslint/eslint/issues/7351
+        {
+            code: "(class { set foo(UNUSED) {} })",
+            parserOptions: {ecmaVersion: 6}
+        },
+        {
+            code: "class Foo { set bar(UNUSED) {} } console.log(Foo)",
+            parserOptions: {ecmaVersion: 6}
+        }
     ],
     invalid: [
         { code: "function foox() { return foox(); }", errors: [definedError("foox")] },