Fix: max-len: ignoreTemplateLiterals: handle 3+ lines (fixes #7125)…

… (#7138)
eslint · Sep 16, 2016 · 28ddcf8 · 28ddcf8
1 parent 660e091
commit 28ddcf8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/rules/max-len.js b/lib/rules/max-len.js
@@ -235,8 +235,9 @@ module.exports = {
          * @private
          */
         function groupByLineNumber(acc, node) {
-            ensureArrayAndPush(acc, node.loc.start.line, node);
-            ensureArrayAndPush(acc, node.loc.end.line, node);
+            for (let i = node.loc.start.line; i <= node.loc.end.line; ++i) {
+                ensureArrayAndPush(acc, i, node);
+            }
             return acc;
         }
 

diff --git a/tests/lib/rules/max-len.js b/tests/lib/rules/max-len.js
@@ -100,6 +100,10 @@ ruleTester.run("max-len", rule, {
             code: "var str = \"this is a very long string\\\nwith continuation\";",
             options: [29, 4, { ignoreStrings: true }]
         },
+        {
+            code: "var str = \"this is a very long string\\\nwith continuation\\\nand with another very very long continuation\\\nand ending\";",
+            options: [29, 4, { ignoreStrings: true }]
+        },
         {
             code: "var foo = veryLongIdentifier;\nvar bar = `this is a very long string`;",
             options: [29, 4, { ignoreTemplateLiterals: true }],
@@ -110,6 +114,11 @@ ruleTester.run("max-len", rule, {
             options: [29, 4, { ignoreTemplateLiterals: true }],
             parserOptions
         },
+        {
+            code: "var foo = veryLongIdentifier;\nvar bar = `this is a very long string\nand this is another line that is very long\nand here is another\n and another!`;",
+            options: [29, 4, { ignoreTemplateLiterals: true }],
+            parserOptions
+        },
 
         // check indented comment lines - https://github.com/eslint/eslint/issues/6322
         {