Fix: balanced false positive in spaced-comment (fixes #6689) (#6692)

eslint · Jul 18, 2016 · 3f206dd · 3f206dd
1 parent 57f1676
commit 3f206dd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/rules/spaced-comment.js b/lib/rules/spaced-comment.js
@@ -342,7 +342,7 @@ module.exports = {
                     }
                 }
 
-                if (balanced && !endMatch) {
+                if (balanced && type === "block" && !endMatch) {
                     reportEnd(node, "Expected space or tab before '*/' in comment");
                 }
             } else {
@@ -354,7 +354,7 @@ module.exports = {
                     }
                 }
 
-                if (endMatch && balanced) {
+                if (balanced && type === "block" && endMatch) {
                     reportEnd(node, "Unexpected space or tab before '*/' in comment", endMatch);
                 }
             }

diff --git a/tests/lib/rules/spaced-comment.js b/tests/lib/rules/spaced-comment.js
@@ -171,6 +171,14 @@ ruleTester.run("spaced-comment", rule, {
             code: "//\n",
             options: ["always"]
         },
+        {
+            code: "// space only at start; valid since balanced doesn't apply to line comments",
+            options: ["always", { block: { balanced: true }}]
+        },
+        {
+            code: "//space only at end; valid since balanced doesn't apply to line comments ",
+            options: ["never", { block: { balanced: true }}]
+        },
 
         // block comments
         {