Merge pull request #3989 from dominicbarnes/ignored-files-should-not-…

…stat Ignored files should not throw errors during CLI
eslint · Oct 2, 2015 · 45863c1 · 45863c1
2 parents fa830ea + 564051d
commit 45863c1
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/lib/cli-engine.js b/lib/cli-engine.js
@@ -556,9 +556,12 @@ CLIEngine.prototype = {
          */
         function executeOnFile(filename) {
             var shouldIgnore = ignoredPaths.contains(filename);
-            filename = fs.realpathSync(filename);
+            if (shouldIgnore) {
+                return;
+            }
 
-            if (processed[filename] || shouldIgnore) {
+            filename = fs.realpathSync(filename);
+            if (processed[filename]) {
                 return;
             }
 

diff --git a/tests/lib/cli-engine.js b/tests/lib/cli-engine.js
@@ -712,6 +712,27 @@ describe("CLIEngine", function() {
             assert.equal(report.results[0].messages.length, 0);
         });
 
+        it("should not fail if an ignored file cannot be resolved", function() {
+
+            var fakeFS = leche.fake(fs),
+                LocalCLIEngine = proxyquire("../../lib/cli-engine", {
+                    fs: fakeFS
+                });
+
+            fakeFS.realpathSync = function() {
+                throw new Error("this error should not happen");
+            };
+
+            engine = new LocalCLIEngine({
+                ignorePattern: "tests"
+            });
+
+            assert.doesNotThrow(function() {
+                engine.executeOnFiles(["tests/fixtures/single-quoted.js"]);
+            });
+
+        });
+
         describe("Fix Mode", function() {
 
             it("should return fixed text on multiple files when in fix mode", function() {