Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
christian-bromann committed May 19, 2023
1 parent 5c99eed commit 474eb61
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
2 changes: 1 addition & 1 deletion lib/linter/rules.js
Expand Up @@ -56,7 +56,7 @@ class Rules {
*/
get(ruleId) {
if (typeof this._rules[ruleId] === "string") {
this.define(ruleId, require(`../rules/${this._rules[ruleId]}`));
this.define(ruleId, require(this._rules[ruleId]));
}
if (this._rules[ruleId]) {
return this._rules[ruleId];
Expand Down
11 changes: 5 additions & 6 deletions package.json
Expand Up @@ -104,10 +104,10 @@
"devDependencies": {
"@babel/core": "^7.4.3",
"@babel/preset-env": "^7.4.3",
"@wdio/browser-runner": "^8.10.2",
"@wdio/cli": "^8.10.2",
"@wdio/concise-reporter": "^8.10.2",
"@wdio/mocha-framework": "^8.10.2",
"@wdio/browser-runner": "^8.10.4",
"@wdio/cli": "^8.10.4",
"@wdio/concise-reporter": "^8.10.4",
"@wdio/mocha-framework": "^8.10.4",
"babel-loader": "^8.0.5",
"c8": "^7.12.0",
"chai": "^4.0.1",
Expand Down Expand Up @@ -159,9 +159,8 @@
"sinon": "^11.0.0",
"temp": "^0.9.0",
"vite-plugin-commonjs": "^0.6.2",
"vite-plugin-dynamic-import": "^1.2.7",
"wdio-chromedriver-service": "^8.1.1",
"webdriverio": "^8.10.2",
"webdriverio": "^8.10.4",
"webpack": "^5.23.0",
"webpack-cli": "^4.5.0",
"yorkie": "^2.0.0"
Expand Down
4 changes: 3 additions & 1 deletion tests/lib/linter/linter.js
Expand Up @@ -15,8 +15,8 @@ const { assert } = require("chai"),
esprima = require("esprima"),
testParsers = require("../../fixtures/parsers/linter-test-parsers");

const { Linter } = require("../../../lib/linter");
const { FlatConfigArray } = require("../../../lib/config/flat-config-array");
const { Linter } = require("../../../build/eslint.js");

//------------------------------------------------------------------------------
// Constants
Expand Down Expand Up @@ -48,6 +48,8 @@ function getVariable(scope, name) {
*/
const ESLINT_ENV = "eslint-env";

process.cwd = () => "/";

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
Expand Down
6 changes: 1 addition & 5 deletions wdio.conf.js
@@ -1,7 +1,6 @@
"use strict";

const commonjs = require("vite-plugin-commonjs");
const dynamicImport = require("vite-plugin-dynamic-import");

exports.config = {

Expand All @@ -21,10 +20,7 @@ exports.config = {
assert: "rollup-plugin-node-polyfills/polyfills/assert"
}
},
plugins: [
commonjs(),
dynamicImport.default()
]
plugins: [commonjs()]
}
}],

Expand Down

0 comments on commit 474eb61

Please sign in to comment.