Fix: Normalizes messages so all end with a period (fixes #6762) (#6807)

eslint · Aug 1, 2016 · 4ca809e · 4ca809e
1 parent c7488ac
commit 4ca809e
Show file tree

Hide file tree

Showing 59 changed files with 498 additions and 499 deletions.
diff --git a/lib/rules/accessor-pairs.js b/lib/rules/accessor-pairs.js
@@ -139,9 +139,9 @@ module.exports = {
             }
 
             if (checkSetWithoutGet && isSetPresent && !isGetPresent) {
-                context.report(node, "Getter is not present");
+                context.report(node, "Getter is not present.");
             } else if (checkGetWithoutSet && isGetPresent && !isSetPresent) {
-                context.report(node, "Setter is not present");
+                context.report(node, "Setter is not present.");
             }
         }
 

diff --git a/lib/rules/array-bracket-spacing.js b/lib/rules/array-bracket-spacing.js
@@ -75,7 +75,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "There should be no space after '" + token.value + "'",
+                message: "There should be no space after '" + token.value + "'.",
                 fix: function(fixer) {
                     let nextToken = sourceCode.getTokenAfter(token);
 
@@ -94,7 +94,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "There should be no space before '" + token.value + "'",
+                message: "There should be no space before '" + token.value + "'.",
                 fix: function(fixer) {
                     let previousToken = sourceCode.getTokenBefore(token);
 
@@ -113,7 +113,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "A space is required after '" + token.value + "'",
+                message: "A space is required after '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.insertTextAfter(token, " ");
                 }
@@ -130,7 +130,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "A space is required before '" + token.value + "'",
+                message: "A space is required before '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.insertTextBefore(token, " ");
                 }

diff --git a/lib/rules/arrow-parens.js b/lib/rules/arrow-parens.js
@@ -27,7 +27,7 @@ module.exports = {
 
     create: function(context) {
         let message = "Expected parentheses around arrow function argument.";
-        let asNeededMessage = "Unexpected parentheses around single function argument";
+        let asNeededMessage = "Unexpected parentheses around single function argument.";
         let asNeeded = context.options[0] === "as-needed";
 
         let sourceCode = context.getSourceCode();

diff --git a/lib/rules/arrow-spacing.js b/lib/rules/arrow-spacing.js
@@ -92,7 +92,7 @@ module.exports = {
                 if (countSpace.before === 0) {
                     context.report({
                         node: tokens.before,
-                        message: "Missing space before =>",
+                        message: "Missing space before =>.",
                         fix: function(fixer) {
                             return fixer.insertTextBefore(tokens.arrow, " ");
                         }
@@ -104,7 +104,7 @@ module.exports = {
                 if (countSpace.before > 0) {
                     context.report({
                         node: tokens.before,
-                        message: "Unexpected space before =>",
+                        message: "Unexpected space before =>.",
                         fix: function(fixer) {
                             return fixer.removeRange([tokens.before.range[1], tokens.arrow.range[0]]);
                         }
@@ -118,7 +118,7 @@ module.exports = {
                 if (countSpace.after === 0) {
                     context.report({
                         node: tokens.after,
-                        message: "Missing space after =>",
+                        message: "Missing space after =>.",
                         fix: function(fixer) {
                             return fixer.insertTextAfter(tokens.arrow, " ");
                         }
@@ -130,7 +130,7 @@ module.exports = {
                 if (countSpace.after > 0) {
                     context.report({
                         node: tokens.after,
-                        message: "Unexpected space after =>",
+                        message: "Unexpected space after =>.",
                         fix: function(fixer) {
                             return fixer.removeRange([tokens.arrow.range[1], tokens.after.range[0]]);
                         }

diff --git a/lib/rules/computed-property-spacing.js b/lib/rules/computed-property-spacing.js
@@ -46,7 +46,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "There should be no space after '" + token.value + "'",
+                message: "There should be no space after '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.removeRange([token.range[1], tokenAfter.range[0]]);
                 }
@@ -64,7 +64,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "There should be no space before '" + token.value + "'",
+                message: "There should be no space before '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.removeRange([tokenBefore.range[1], token.range[0]]);
                 }
@@ -81,7 +81,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "A space is required after '" + token.value + "'",
+                message: "A space is required after '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.insertTextAfter(token, " ");
                 }
@@ -98,7 +98,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "A space is required before '" + token.value + "'",
+                message: "A space is required before '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.insertTextBefore(token, " ");
                 }

diff --git a/lib/rules/id-blacklist.js b/lib/rules/id-blacklist.js
@@ -67,7 +67,7 @@ module.exports = {
          * @private
          */
         function report(node) {
-            context.report(node, "Identifier '{{name}}' is blacklisted", {
+            context.report(node, "Identifier '{{name}}' is blacklisted.", {
                 name: node.name
             });
         }

diff --git a/lib/rules/id-length.js b/lib/rules/id-length.js
@@ -103,8 +103,8 @@ module.exports = {
                     context.report(
                         node,
                         isShort ?
-                            "Identifier name '{{name}}' is too short. (< {{min}})" :
-                            "Identifier name '{{name}}' is too long. (> {{max}})",
+                            "Identifier name '{{name}}' is too short (< {{min}})." :
+                            "Identifier name '{{name}}' is too long (> {{max}}).",
                         { name: name, min: minLength, max: maxLength }
                     );
                 }

diff --git a/lib/rules/max-lines.js b/lib/rules/max-lines.js
@@ -139,7 +139,7 @@ module.exports = {
                 if (lines.length > max) {
                     context.report({
                         loc: { line: 1, column: 0 },
-                        message: "File must be at most " + max + " lines long"
+                        message: "File must be at most " + max + " lines long."
                     });
                 }
             }

diff --git a/lib/rules/new-parens.js b/lib/rules/new-parens.js
@@ -32,7 +32,7 @@ module.exports = {
                 });
 
                 if (prenticesTokens.length < 2) {
-                    context.report(node, "Missing '()' invoking a constructor");
+                    context.report(node, "Missing '()' invoking a constructor.");
                 }
             }
         };

diff --git a/lib/rules/no-continue.js b/lib/rules/no-continue.js
@@ -24,7 +24,7 @@ module.exports = {
 
         return {
             ContinueStatement: function(node) {
-                context.report(node, "Unexpected use of continue statement");
+                context.report(node, "Unexpected use of continue statement.");
             }
         };
 

diff --git a/lib/rules/no-invalid-regexp.js b/lib/rules/no-invalid-regexp.js
@@ -72,15 +72,15 @@ module.exports = {
                 try {
                     void new RegExp(node.arguments[0].value);
                 } catch (e) {
-                    context.report(node, e.message);
+                    context.report(node, e.message + ".");
                 }
 
                 if (flags) {
 
                     try {
                         espree.parse("/./" + flags, context.parserOptions);
                     } catch (ex) {
-                        context.report(node, "Invalid flags supplied to RegExp constructor '" + flags + "'");
+                        context.report(node, "Invalid flags supplied to RegExp constructor '" + flags + "'.");
                     }
                 }
 

diff --git a/lib/rules/no-irregular-whitespace.js b/lib/rules/no-irregular-whitespace.js
@@ -153,7 +153,7 @@ module.exports = {
                         column: match.index
                     };
 
-                    errors.push([node, location, "Irregular whitespace not allowed"]);
+                    errors.push([node, location, "Irregular whitespace not allowed."]);
                 }
             });
         }
@@ -181,7 +181,7 @@ module.exports = {
                     column: sourceLines[lineIndex].length
                 };
 
-                errors.push([node, location, "Irregular whitespace not allowed"]);
+                errors.push([node, location, "Irregular whitespace not allowed."]);
                 lastLineIndex = lineIndex;
             }
         }

diff --git a/lib/rules/no-loop-func.js b/lib/rules/no-loop-func.js
@@ -185,7 +185,7 @@ module.exports = {
             if (references.length > 0 &&
                 !references.every(isSafe.bind(null, node, loopNode))
             ) {
-                context.report(node, "Don't make functions within a loop");
+                context.report(node, "Don't make functions within a loop.");
             }
         }
 

diff --git a/lib/rules/no-magic-numbers.js b/lib/rules/no-magic-numbers.js
@@ -128,14 +128,14 @@ module.exports = {
                     if (enforceConst && parent.parent.kind !== "const") {
                         context.report({
                             node: node,
-                            message: "Number constants declarations must use 'const'"
+                            message: "Number constants declarations must use 'const'."
                         });
                     }
                 } else if (okTypes.indexOf(parent.type) === -1 ||
                     (parent.type === "AssignmentExpression" && parent.operator !== "=")) {
                     context.report({
                         node: node,
-                        message: "No magic number: " + raw
+                        message: "No magic number: " + raw + "."
                     });
                 }
             }

diff --git a/lib/rules/no-negated-in-lhs.js b/lib/rules/no-negated-in-lhs.js
@@ -26,7 +26,7 @@ module.exports = {
 
             BinaryExpression: function(node) {
                 if (node.operator === "in" && node.left.type === "UnaryExpression" && node.left.operator === "!") {
-                    context.report(node, "The 'in' expression's left operand is negated");
+                    context.report(node, "The 'in' expression's left operand is negated.");
                 }
             }
         };

diff --git a/lib/rules/no-nested-ternary.js b/lib/rules/no-nested-ternary.js
@@ -26,7 +26,7 @@ module.exports = {
             ConditionalExpression: function(node) {
                 if (node.alternate.type === "ConditionalExpression" ||
                         node.consequent.type === "ConditionalExpression") {
-                    context.report(node, "Do not nest ternary expressions");
+                    context.report(node, "Do not nest ternary expressions.");
                 }
             }
         };

diff --git a/lib/rules/no-redeclare.js b/lib/rules/no-redeclare.js
@@ -52,7 +52,7 @@ module.exports = {
                     for (let i = (hasBuiltin ? 0 : 1), l = variable.identifiers.length; i < l; i++) {
                         context.report(
                             variable.identifiers[i],
-                            "'{{a}}' is already defined",
+                            "'{{a}}' is already defined.",
                             {a: variable.name});
                     }
                 }

diff --git a/lib/rules/no-restricted-globals.js b/lib/rules/no-restricted-globals.js
@@ -40,7 +40,7 @@ module.exports = {
          * @private
          */
         function reportReference(reference) {
-            context.report(reference.identifier, "Unexpected use of '{{name}}'", {
+            context.report(reference.identifier, "Unexpected use of '{{name}}'.", {
                 name: reference.identifier.name
             });
         }
@@ -77,4 +77,3 @@ module.exports = {
         };
     }
 };
-
diff --git a/lib/rules/no-unneeded-ternary.js b/lib/rules/no-unneeded-ternary.js
@@ -60,9 +60,9 @@ module.exports = {
 
             ConditionalExpression: function(node) {
                 if (isBooleanLiteral(node.alternate) && isBooleanLiteral(node.consequent)) {
-                    context.report(node, node.consequent.loc.start, "Unnecessary use of boolean literals in conditional expression");
+                    context.report(node, node.consequent.loc.start, "Unnecessary use of boolean literals in conditional expression.");
                 } else if (!defaultAssignment && matchesDefaultAssignment(node)) {
-                    context.report(node, node.consequent.loc.start, "Unnecessary use of conditional expression for default assignment");
+                    context.report(node, node.consequent.loc.start, "Unnecessary use of conditional expression for default assignment.");
                 }
             }
         };

diff --git a/lib/rules/no-unsafe-finally.js b/lib/rules/no-unsafe-finally.js
@@ -83,7 +83,7 @@ module.exports = {
         function check(node) {
             if (isInFinallyBlock(node, node.label)) {
                 context.report({
-                    message: "Unsafe usage of " + node.type,
+                    message: "Unsafe usage of " + node.type + ".",
                     node: node,
                     line: node.loc.line,
                     column: node.loc.column

diff --git a/lib/rules/no-use-before-define.js b/lib/rules/no-use-before-define.js
@@ -208,7 +208,7 @@ module.exports = {
                 // Reports.
                 context.report({
                     node: reference.identifier,
-                    message: "'{{name}}' was used before it was defined",
+                    message: "'{{name}}' was used before it was defined.",
                     data: reference.identifier
                 });
             });

diff --git a/lib/rules/no-useless-escape.js b/lib/rules/no-useless-escape.js
@@ -90,7 +90,7 @@ module.exports = {
                         line: node.loc.start.line,
                         column: node.loc.start.column + elm.index
                     },
-                    message: "Unnecessary escape character: " + elm[0]
+                    message: "Unnecessary escape character: " + elm[0] + "."
                 });
             }
         }

diff --git a/lib/rules/object-curly-spacing.js b/lib/rules/object-curly-spacing.js
@@ -74,7 +74,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "There should be no space after '" + token.value + "'",
+                message: "There should be no space after '" + token.value + "'.",
                 fix: function(fixer) {
                     let nextToken = context.getSourceCode().getTokenAfter(token);
 
@@ -93,7 +93,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "There should be no space before '" + token.value + "'",
+                message: "There should be no space before '" + token.value + "'.",
                 fix: function(fixer) {
                     let previousToken = context.getSourceCode().getTokenBefore(token);
 
@@ -112,7 +112,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "A space is required after '" + token.value + "'",
+                message: "A space is required after '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.insertTextAfter(token, " ");
                 }
@@ -129,7 +129,7 @@ module.exports = {
             context.report({
                 node: node,
                 loc: token.loc.start,
-                message: "A space is required before '" + token.value + "'",
+                message: "A space is required before '" + token.value + "'.",
                 fix: function(fixer) {
                     return fixer.insertTextBefore(token, " ");
                 }

diff --git a/lib/rules/object-property-newline.js b/lib/rules/object-property-newline.js
@@ -33,8 +33,8 @@ module.exports = {
     create: function(context) {
         let allowSameLine = context.options[0] && Boolean(context.options[0].allowMultiplePropertiesPerLine);
         let errorMessage = allowSameLine ?
-            "Object properties must go on a new line if they aren't all on the same line" :
-            "Object properties must go on a new line";
+            "Object properties must go on a new line if they aren't all on the same line." :
+            "Object properties must go on a new line.";
 
         let sourceCode = context.getSourceCode();
 

diff --git a/lib/rules/operator-linebreak.js b/lib/rules/operator-linebreak.js
@@ -123,7 +123,7 @@ module.exports = {
                 context.report(node, {
                     line: operatorToken.loc.end.line,
                     column: operatorToken.loc.end.column
-                }, "There should be no line break before or after '" + operator + "'");
+                }, "There should be no line break before or after '" + operator + "'.");
 
             }
         }

diff --git a/lib/rules/prefer-reflect.js b/lib/rules/prefer-reflect.js
@@ -79,7 +79,7 @@ module.exports = {
          * @returns {void}
          */
         function report(node, existing, substitute) {
-            context.report(node, "Avoid using {{existing}}, instead use {{substitute}}", {
+            context.report(node, "Avoid using {{existing}}, instead use {{substitute}}.", {
                 existing: existing,
                 substitute: substitute
             });