Update: Omit setter param from no-unused-vars (fixes #2133)

eslint · Mar 24, 2015 · 5749bfe · 5749bfe
1 parent 0653cf7
commit 5749bfe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -108,12 +108,20 @@ module.exports = function(context) {
                 if (scope.type === "function" && variables[i].name === "arguments" && variables[i].identifiers.length === 0) {
                     continue;
                 }
-                var type = variables[i].defs[0].type;
+
+                var def = variables[i].defs[0],
+                    type = def.type;
 
                 // skip catch variables
                 if (type === "CatchClause") {
                     continue;
                 }
+
+                // skip any setter argument
+                if (type === "Parameter" && def.node.parent.type === "Property" && def.node.parent.kind === "set") {
+                    continue;
+                }
+
                 // if "args" option is "none", skip any parameter
                 if (config.args === "none" && type === "Parameter") {
                     continue;

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
@@ -32,6 +32,7 @@ eslintTester.addRuleTest("lib/rules/no-unused-vars", {
         "var foo = 5;\n\nwhile (true) {\n  console.log(foo);\n  break;\n}",
         { code: "for (let prop in box) {\n        box[prop] = parseInt(box[prop]);\n}", ecmaFeatures: { blockBindings: true }},
         "var box = {a: 2};\n    for (var prop in box) {\n        box[prop] = parseInt(box[prop]);\n}",
+        "f({ set foo(a) { return; } });",
         { code: "a; var a;", args: [1, "all"] },
         { code: "var a=10; alert(a);", args: [1, "all"] },
         { code: "var a=10; (function() { alert(a); })();", args: [1, "all"] },