chore: remove unused tools rule-types.json, update-rule-types.js (#18125

)

* chore: remove unused tools: rule-types.json, update-rule-types.js

* Reduce scope of Makefile.js changes

Makefile.js

@@ -674,7 +674,6 @@ target.checkRuleFiles = function() {
 
     echo("Validating rules");
 
-    const ruleTypes = require("./tools/rule-types.json");
     let errors = 0;
 
     RULE_FILES.forEach(filename => {
@@ -686,14 +685,6 @@ target.checkRuleFiles = function() {
         const ruleCode = cat(filename);
         const knownHeaders = ["Rule Details", "Options", "Environments", "Examples", "Known Limitations", "When Not To Use It", "Compatibility"];
 
-        /**
-         * Check if basename is present in rule-types.json file.
-         * @returns {boolean} true if present
-         * @private
-         */
-        function isInRuleTypes() {
-            return Object.hasOwn(ruleTypes, basename);
-        }
 
         /**
          * Check if id is present in title
@@ -776,12 +767,6 @@ target.checkRuleFiles = function() {
             }
         }
 
-        // check for recommended configuration
-        if (!isInRuleTypes()) {
-            console.error("Missing setting for %s in tools/rule-types.json", basename);
-            errors++;
-        }
-
         // check parity between rules index file and rules directory
         const ruleIdsInIndex = require("./lib/rules/index");
         const ruleDef = ruleIdsInIndex.get(basename);