add tests

eslint · Dec 15, 2023 · 6814836 · 6814836
1 parent 5531723
commit 6814836
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/rules/no-implicit-coercion.js b/lib/rules/no-implicit-coercion.js
@@ -303,7 +303,7 @@ module.exports = {
 
                 // -(-foo)
                 operatorAllowed = options.allow.includes("- -");
-                if (!operatorAllowed && node.operator === "-" && node.argument.type === "UnaryExpression" && node.argument.operator === "-") {
+                if (!operatorAllowed && options.number && node.operator === "-" && node.argument.type === "UnaryExpression" && node.argument.operator === "-") {
                     const recommendation = `Number(${sourceCode.getText(node.argument.argument)})`;
 
                     report(node, recommendation, true);
@@ -327,7 +327,7 @@ module.exports = {
 
                 // foo - 0
                 operatorAllowed = options.allow.includes("-");
-                if (!operatorAllowed && node.operator === "-" && isNumeric(node.right) && node.right.value === 0) {
+                if (!operatorAllowed && options.number && node.operator === "-" && isNumeric(node.right) && node.right.value === 0) {
                     const recommendation = `Number(${sourceCode.getText(node.left)})`;
 
                     report(node, recommendation, true);

diff --git a/tests/lib/rules/no-implicit-coercion.js b/tests/lib/rules/no-implicit-coercion.js
@@ -69,13 +69,17 @@ ruleTester.run("no-implicit-coercion", rule, {
         { code: "!!foo", options: [{ boolean: false }] },
         { code: "~foo.indexOf(1)", options: [{ boolean: false }] },
         { code: "+foo", options: [{ number: false }] },
+        { code: "-(-foo)", options: [{ number: false }] },
+        { code: "foo - 0", options: [{ number: false }] },
         { code: "1*foo", options: [{ number: false }] },
         { code: "\"\"+foo", options: [{ string: false }] },
         { code: "foo += \"\"", options: [{ string: false }] },
         { code: "var a = !!foo", options: [{ boolean: true, allow: ["!!"] }] },
         { code: "var a = ~foo.indexOf(1)", options: [{ boolean: true, allow: ["~"] }] },
         { code: "var a = ~foo", options: [{ boolean: true }] },
         { code: "var a = 1 * foo", options: [{ boolean: true, allow: ["*"] }] },
+        { code: "- -foo", options: [{ number: true, allow: ["- -"] }] },
+        { code: "foo - 0", options: [{ number: true, allow: ["-"] }] },
         { code: "var a = +foo", options: [{ boolean: true, allow: ["+"] }] },
         { code: "var a = \"\" + foo", options: [{ boolean: true, string: true, allow: ["+"] }] },