feat!: Switch Linter to flat config by default

Refs #13481
eslint · Dec 13, 2023 · 78ba2f5 · 78ba2f5
1 parent 7d5e5f6
commit 78ba2f5
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 37 deletions.
diff --git a/lib/cli-engine/cli-engine.js b/lib/cli-engine/cli-engine.js
@@ -639,7 +639,7 @@ class CLIEngine {
         });
         const lintResultCache =
             options.cache ? new LintResultCache(cacheFilePath, options.cacheStrategy) : null;
-        const linter = new Linter({ cwd: options.cwd });
+        const linter = new Linter({ cwd: options.cwd, configType: "eslintrc" });
 
         /** @type {ConfigArray[]} */
         const lastConfigArrays = [configArrayFactory.getConfigArrayForFile()];

diff --git a/lib/linter/linter.js b/lib/linter/linter.js
@@ -1214,9 +1214,9 @@ class Linter {
      * Initialize the Linter.
      * @param {Object} [config] the config object
      * @param {string} [config.cwd] path to a directory that should be considered as the current working directory, can be undefined.
-     * @param {"flat"|"eslintrc"} [config.configType="eslintrc"] the type of config used.
+     * @param {"flat"|"eslintrc"} [config.configType="flat"] the type of config used.
      */
-    constructor({ cwd, configType } = {}) {
+    constructor({ cwd, configType = "flat" } = {}) {
         internalSlotsMap.set(this, {
             cwd: normalizeCwd(cwd),
             lastConfigArray: null,

diff --git a/lib/rule-tester/rule-tester.js b/lib/rule-tester/rule-tester.js
@@ -498,7 +498,7 @@ class RuleTester {
          * @type {Object}
          */
         this.rules = {};
-        this.linter = new Linter();
+        this.linter = new Linter({ configType: "eslintrc" });
     }
 
     /**

diff --git a/tests/lib/linter/linter.js b/tests/lib/linter/linter.js
@@ -59,7 +59,7 @@ describe("Linter", () => {
     let linter;
 
     beforeEach(() => {
-        linter = new Linter();
+        linter = new Linter({ configType: "eslintrc" });
     });
 
     afterEach(() => {
@@ -4133,7 +4133,7 @@ var a = "test2";
 
         it("should get cwd correctly in the context", () => {
             const cwd = "cwd";
-            const linterWithOption = new Linter({ cwd });
+            const linterWithOption = new Linter({ cwd, configType: "eslintrc" });
             let spy;
 
             linterWithOption.defineRule("checker", {
@@ -4152,7 +4152,7 @@ var a = "test2";
 
         it("should assign process.cwd() to it if cwd is undefined", () => {
             let spy;
-            const linterWithOption = new Linter({ });
+            const linterWithOption = new Linter({ configType: "eslintrc" });
 
             linterWithOption.defineRule("checker", {
                 create(context) {
@@ -7690,8 +7690,8 @@ var a = "test2";
         let linter2 = null;
 
         beforeEach(() => {
-            linter1 = new Linter();
-            linter2 = new Linter();
+            linter1 = new Linter({ configType: "eslintrc" });
+            linter2 = new Linter({ configType: "eslintrc" });
         });
 
         describe("rules", () => {
@@ -17505,32 +17505,6 @@ var a = "test2";
         });
     });
 
-    describe("Mutability", () => {
-        let linter1 = null;
-        let linter2 = null;
-
-        beforeEach(() => {
-            linter1 = new Linter();
-            linter2 = new Linter();
-        });
-
-        describe("rules", () => {
-            it("with no changes, same rules are loaded", () => {
-                assert.sameDeepMembers(Array.from(linter1.getRules().keys()), Array.from(linter2.getRules().keys()));
-            });
-
-            it("loading rule in one doesn't change the other", () => {
-                linter1.defineRule("mock-rule", {
-                    create: () => ({})
-                });
-
-                assert.isTrue(linter1.getRules().has("mock-rule"), "mock rule is present");
-                assert.isFalse(linter2.getRules().has("mock-rule"), "mock rule is not present");
-            });
-        });
-    });
-
-
     describe("processors", () => {
         let receivedFilenames = [];
         let receivedPhysicalFilenames = [];

diff --git a/tests/lib/source-code/source-code.js b/tests/lib/source-code/source-code.js
@@ -29,7 +29,7 @@ const DEFAULT_CONFIG = {
     range: true,
     loc: true
 };
-const linter = new Linter();
+const linter = new Linter({ configType: "eslintrc" });
 const flatLinter = new Linter({ configType: "flat" });
 const AST = espree.parse("let foo = bar;", DEFAULT_CONFIG),
     TEST_CODE = "var answer = 6 * 7;",

diff --git a/tests/tools/eslint-fuzzer.js b/tests/tools/eslint-fuzzer.js
@@ -23,7 +23,7 @@ describe("eslint-fuzzer", function() {
      */
     this.timeout(15000); // eslint-disable-line no-invalid-this -- Mocha timeout
 
-    const linter = new eslint.Linter();
+    const linter = new eslint.Linter({ configType: "eslintrc" });
     const coreRules = linter.getRules();
     const fixableRuleNames = Array.from(coreRules)
         .filter(rulePair => rulePair[1].meta && rulePair[1].meta.fixable)