Fix: Handle await expressions correctly in no-unused-expressions (#…

…7175) (refs #7101)
eslint · Sep 19, 2016 · 7ea3e4b · 7ea3e4b
1 parent 16bb802
commit 7ea3e4b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rules/no-unused-expressions.js b/lib/rules/no-unused-expressions.js
@@ -101,7 +101,7 @@ module.exports = {
                 }
             }
 
-            return /^(?:Assignment|Call|New|Update|Yield)Expression$/.test(node.type) ||
+            return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/.test(node.type) ||
                 (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0);
         }
 

diff --git a/tests/lib/rules/no-unused-expressions.js b/tests/lib/rules/no-unused-expressions.js
@@ -42,6 +42,24 @@ ruleTester.run("no-unused-expressions", rule, {
         {
             code: "function* foo(){ yield 0; }",
             parserOptions: { ecmaVersion: 6 }
+        },
+        {
+            code: "async function foo() { await 5; }",
+            parserOptions: { ecmaVersion: 8 }
+        },
+        {
+            code: "async function foo() { await foo.bar; }",
+            parserOptions: { ecmaVersion: 8 }
+        },
+        {
+            code: "async function foo() { bar && await baz; }",
+            options: [{ allowShortCircuit: true }],
+            parserOptions: { ecmaVersion: 8 }
+        },
+        {
+            code: "async function foo() { foo ? await bar : await baz; }",
+            options: [{ allowTernary: true }],
+            parserOptions: { ecmaVersion: 8 }
         }
     ],
     invalid: [