Breaking: update eslint:recommended for 4.0.0 (fixes #8236) (#8372)

This adds no-useless-escape, no-compare-neg-zero, and array-callback-return to eslint:recommended.
eslint · Apr 3, 2017 · 9a9d916 · 9a9d916
1 parent b0c63f0
commit 9a9d916
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/conf/eslint-recommended.js b/conf/eslint-recommended.js
@@ -17,7 +17,7 @@ module.exports = {
         /* eslint-enable sort-keys */
         "accessor-pairs": "off",
         "array-bracket-spacing": "off",
-        "array-callback-return": "off",
+        "array-callback-return": "error",
         "arrow-body-style": "off",
         "arrow-parens": "off",
         "arrow-spacing": "off",
@@ -83,7 +83,7 @@ module.exports = {
         "no-case-declarations": "error",
         "no-catch-shadow": "off",
         "no-class-assign": "error",
-        "no-compare-neg-zero": "off",
+        "no-compare-neg-zero": "error",
         "no-cond-assign": "error",
         "no-confusing-arrow": "off",
         "no-console": "error",
@@ -201,7 +201,7 @@ module.exports = {
         "no-useless-computed-key": "off",
         "no-useless-concat": "off",
         "no-useless-constructor": "off",
-        "no-useless-escape": "off",
+        "no-useless-escape": "error",
         "no-useless-rename": "off",
         "no-useless-return": "off",
         "no-var": "off",
@@ -211,7 +211,7 @@ module.exports = {
         "no-with": "off",
         "nonblock-statement-body-position": "off",
         "object-curly-newline": "off",
-        "object-curly-spacing": ["off", "never"],
+        "object-curly-spacing": "off",
         "object-property-newline": "off",
         "object-shorthand": "off",
         "one-var": "off",

diff --git a/lib/rules/array-callback-return.js b/lib/rules/array-callback-return.js
@@ -138,7 +138,7 @@ module.exports = {
         docs: {
             description: "enforce `return` statements in callbacks of array methods",
             category: "Best Practices",
-            recommended: false
+            recommended: true
         },
 
         schema: []

diff --git a/lib/rules/no-compare-neg-zero.js b/lib/rules/no-compare-neg-zero.js
@@ -13,7 +13,7 @@ module.exports = {
         docs: {
             description: "disallow comparing against -0",
             category: "Possible Errors",
-            recommended: false
+            recommended: true
         },
         fixable: null,
         schema: []

diff --git a/lib/rules/no-useless-escape.js b/lib/rules/no-useless-escape.js
@@ -75,7 +75,7 @@ module.exports = {
         docs: {
             description: "disallow unnecessary escape characters",
             category: "Best Practices",
-            recommended: false
+            recommended: true
         },
 
         schema: []