fix: false negative

eslint · May 15, 2024 · 9f57298 · 9f57298
1 parent 84a88d8
commit 9f57298
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 4 deletions.
diff --git a/docs/src/rules/func-style.md b/docs/src/rules/func-style.md
@@ -59,7 +59,7 @@ This rule has a string option:
 * `"expression"` (default) requires the use of function expressions instead of function declarations
 * `"declaration"` requires the use of function declarations instead of function expressions
 
-This rule has an object option for two exception:
+This rule has an object option for two exceptions:
 
 * `"allowArrowFunctions"`: `true` (default `false`) allows the use of arrow functions. This option applies only when the string option is set to `"declaration"` (arrow functions are always allowed when the string option is set to `"expression"`, regardless of this option)
 * `"overrides"`:

diff --git a/lib/rules/func-style.js b/lib/rules/func-style.js
@@ -65,7 +65,7 @@ module.exports = {
                 if (
                     !enforceDeclarations &&
                     node.parent.type !== "ExportDefaultDeclaration" &&
-                    typeof exportFunctionStyle === "undefined"
+                    (typeof exportFunctionStyle === "undefined" || node.parent.type !== "ExportNamedDeclaration")
                 ) {
                     context.report({ node, messageId: "expression" });
                 }
@@ -84,7 +84,7 @@ module.exports = {
                 if (
                     enforceDeclarations &&
                     node.parent.type === "VariableDeclarator" &&
-                    typeof exportFunctionStyle === "undefined"
+                    (typeof exportFunctionStyle === "undefined" || node.parent.parent.parent.type !== "ExportNamedDeclaration")
                 ) {
                     context.report({ node: node.parent, messageId: "declaration" });
                 }
@@ -116,7 +116,10 @@ module.exports = {
                 const hasThisExpr = stack.pop();
 
                 if (!hasThisExpr && node.parent.type === "VariableDeclarator") {
-                    if (enforceDeclarations && typeof exportFunctionStyle === "undefined") {
+                    if (
+                        enforceDeclarations &&
+                        (typeof exportFunctionStyle === "undefined" || node.parent.parent.parent.type !== "ExportNamedDeclaration")
+                    ) {
                         context.report({ node: node.parent, messageId: "declaration" });
                     }
 

diff --git a/tests/lib/rules/func-style.js b/tests/lib/rules/func-style.js
@@ -290,6 +290,39 @@ ruleTester.run("func-style", rule, {
                     type: "VariableDeclarator"
                 }
             ]
+        },
+        {
+            code: "function foo() {};",
+            options: ["expression", { overrides: { namedExports: "declaration" } }],
+            languageOptions: { ecmaVersion: 6 },
+            errors: [
+                {
+                    messageId: "expression",
+                    type: "FunctionDeclaration"
+                }
+            ]
+        },
+        {
+            code: "var foo = function() {};",
+            options: ["declaration", { overrides: { namedExports: "expression" } }],
+            languageOptions: { ecmaVersion: 6 },
+            errors: [
+                {
+                    messageId: "declaration",
+                    type: "VariableDeclarator"
+                }
+            ]
+        },
+        {
+            code: "var foo = () => {};",
+            options: ["declaration", { overrides: { namedExports: "expression" } }],
+            languageOptions: { ecmaVersion: 6 },
+            errors: [
+                {
+                    messageId: "declaration",
+                    type: "VariableDeclarator"
+                }
+            ]
         }
     ]
 });