fix: no-unused-vars false positive with logical assignment operators (#…

…17320) * fix: no-unused-vars should be corrected in logical assignment operator Fixes #17299 * refactor: use astUtils.isLogicalAssignmentOperator check exception
eslint · Jun 30, 2023 · a36bcb6 · a36bcb6
1 parent c8b1f4d
commit a36bcb6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -466,7 +466,8 @@ module.exports = {
                     (
                         parent.type === "AssignmentExpression" &&
                         parent.left === id &&
-                        isUnusedExpression(parent)
+                        isUnusedExpression(parent) &&
+                        !astUtils.isLogicalAssignmentOperator(parent.operator)
                     ) ||
                     (
                         parent.type === "UpdateExpression" &&

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
@@ -417,6 +417,20 @@ ruleTester.run("no-unused-vars", rule, {
         {
             code: "import.meta",
             parserOptions: { ecmaVersion: 2020, sourceType: "module" }
+        },
+
+        // https://github.com/eslint/eslint/issues/17299
+        {
+            code: "var a; a ||= 1;",
+            parserOptions: { ecmaVersion: 2021 }
+        },
+        {
+            code: "var a; a &&= 1;",
+            parserOptions: { ecmaVersion: 2021 }
+        },
+        {
+            code: "var a; a ??= 1;",
+            parserOptions: { ecmaVersion: 2021 }
         }
     ],
     invalid: [