Breaking: Remove extra rules from eslint:recommended (fixes #10873) (#…

…11357)

Only explicitly recommended rules will be exported in eslint:recommended configuration.

conf/eslint-recommended.js

@@ -9,7 +9,10 @@
 const builtInRules = require("../lib/built-in-rules-index");
 
 module.exports = {
-    rules: Object.assign({}, ...Object.keys(builtInRules).map(ruleId => ({
-        [ruleId]: builtInRules[ruleId].meta.docs.recommended ? "error" : "off"
-    })))
+    rules: Object.assign(
+        {},
+        ...Object.keys(builtInRules)
+            .filter(ruleId => builtInRules[ruleId].meta.docs.recommended)
+            .map(ruleId => ({ [ruleId]: "error" }))
+    )
 };

tests/conf/eslint-recommended.js

@@ -0,0 +1,24 @@
+/**
+ * @fileoverview Tests for eslint:recommended.
+ * @author Kevin Partington
+ */
+
+"use strict";
+
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const assert = require("chai").assert;
+const eslintRecommended = require("../../conf/eslint-recommended");
+const rules = eslintRecommended.rules;
+
+describe("eslint-recommended", () => {
+    it("should configure recommended rules as error", () => {
+        assert.strictEqual(rules["no-undef"], "error");
+    });
+
+    it("should not configure non-recommended rules", () => {
+        assert.notProperty(rules, "camelcase");
+    });
+});

tests/lib/cli-engine.js

@@ -1532,7 +1532,7 @@ describe("CLIEngine", () => {
 
             const report = engine.executeOnFiles(["lib/cli*.js"]);
 
-            assert.deepStrictEqual(
+            assert.sameDeepMembers(
                 report.usedDeprecatedRules,
                 [
                     { ruleId: "indent-legacy", replacedBy: ["indent"] },