Merge pull request #2067 from Kirill89/add-space-infix-ops-options

New: Added option int32Hint for space-infix-ops (fixes #1295)
eslint · Mar 18, 2015 · cd4e45d · cd4e45d
2 parents 66b43cb + 09bd11c
commit cd4e45d
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/docs/rules/space-infix-ops.md b/docs/rules/space-infix-ops.md
@@ -48,4 +48,20 @@ a       + b
 
 ```js
 a ? b : c
-```
+```
+
+### Options
+
+This rule accepts a single options argument with the following defaults:
+
+```json
+"space-infix-ops": [2, {"int32Hint": false}]
+```
+
+### `int32Hint`
+
+Set the `int32Hint` option to `true` (default is `false`) to allow write `a|0` without space.
+
+```js
+var foo = bar|0; // `foo` is forced to be signed 32 bit integer
+```
diff --git a/lib/rules/space-infix-ops.js b/lib/rules/space-infix-ops.js
@@ -9,6 +9,7 @@
 //------------------------------------------------------------------------------
 
 module.exports = function(context) {
+    var int32Hint = context.options[0] ? context.options[0].int32Hint === true : false;
 
     var OPERATORS = [
         "*", "/", "%", "+", "-", "<<", ">>", ">>>", "<", "<=", ">", ">=", "in",
@@ -38,7 +39,9 @@ module.exports = function(context) {
 
     function checkBinary(node) {
         if (!isSpaced(node.left, node.right)) {
-            report(node);
+            if (!(int32Hint && context.getSource(node).substr(-2) === "|0")) {
+                report(node);
+            }
         }
     }
 

diff --git a/tests/lib/rules/space-infix-ops.js b/tests/lib/rules/space-infix-ops.js
@@ -24,7 +24,9 @@ eslintTester.addRuleTest("lib/rules/space-infix-ops", {
         "(a + b) + (c + d)",
         "a = b",
         "a ? b : c",
-        "var a = b"
+        "var a = b",
+        { code: "a|0", args: [2, { int32Hint: true }] },
+        { code: "a |0", args: [2, { int32Hint: true }] }
     ],
     invalid: [
         { code: "a+b", errors: [{ message: "Infix operators must be spaced.", type: "BinaryExpression" }] },
@@ -46,6 +48,7 @@ eslintTester.addRuleTest("lib/rules/space-infix-ops", {
         { code: "var a=b;", errors: [{ message: "Infix operators must be spaced.", type: "VariableDeclarator" }] },
         { code: "var a= b;", errors: [{ message: "Infix operators must be spaced.", type: "VariableDeclarator" }] },
         { code: "var a =b;", errors: [{ message: "Infix operators must be spaced.", type: "VariableDeclarator" }] },
-        { code: "var a = b, c=d;", errors: [{ message: "Infix operators must be spaced.", type: "VariableDeclarator" }] }
+        { code: "var a = b, c=d;", errors: [{ message: "Infix operators must be spaced.", type: "VariableDeclarator" }] },
+        { code: "a| 0", args: [2, { int32Hint: true }], errors: [{ message: "Infix operators must be spaced.", type: "BinaryExpression" }] }
     ]
 });