Update: add fix for no-confusing-arrow

eslint · Mar 29, 2017 · d221dce · d221dce
1 parent 0541eaf
commit d221dce
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/lib/rules/no-confusing-arrow.js b/lib/rules/no-confusing-arrow.js
@@ -33,6 +33,8 @@ module.exports = {
             recommended: false
         },
 
+        fixable: "code",
+
         schema: [{
             type: "object",
             properties: {
@@ -55,7 +57,15 @@ module.exports = {
             const body = node.body;
 
             if (isConditional(body) && !(config.allowParens && astUtils.isParenthesised(sourceCode, body))) {
-                context.report({ node, message: "Arrow function used ambiguously with a conditional expression." });
+                context.report({
+                    node,
+                    message: "Arrow function used ambiguously with a conditional expression.",
+                    fix(fixer) {
+
+                        // if `allowParens` is not set to true dont bother wrapping in parens
+                        return config.allowParens && fixer.replaceText(node.body, `(${sourceCode.getText(node.body)})`);
+                    }
+                });
             }
         }
 

diff --git a/tests/lib/rules/no-confusing-arrow.js b/tests/lib/rules/no-confusing-arrow.js
@@ -28,19 +28,41 @@ ruleTester.run("no-confusing-arrow", rule, {
     invalid: [
         {
             code: "a => 1 ? 2 : 3",
+            output: null,
             errors: [{ message: "Arrow function used ambiguously with a conditional expression." }]
         },
         {
             code: "var x = a => 1 ? 2 : 3",
+            output: null,
             errors: [{ message: "Arrow function used ambiguously with a conditional expression." }]
         },
         {
             code: "var x = (a) => 1 ? 2 : 3",
+            output: null,
             errors: [{ message: "Arrow function used ambiguously with a conditional expression." }]
         },
         {
             code: "var x = a => (1 ? 2 : 3)",
+            output: null,
             errors: [{ message: "Arrow function used ambiguously with a conditional expression." }]
+        },
+        {
+            code: "a => 1 ? 2 : 3",
+            output: "a => (1 ? 2 : 3)",
+            errors: [{ message: "Arrow function used ambiguously with a conditional expression." }],
+            options: [{ allowParens: true }]
+        },
+        {
+            code: "var x = a => 1 ? 2 : 3",
+            output: "var x = a => (1 ? 2 : 3)",
+            errors: [{ message: "Arrow function used ambiguously with a conditional expression." }],
+            options: [{ allowParens: true }]
+        },
+        {
+            code: "var x = (a) => 1 ? 2 : 3",
+            output: "var x = (a) => (1 ? 2 : 3)",
+            errors: [{ message: "Arrow function used ambiguously with a conditional expression." }],
+            options: [{ allowParens: true }]
         }
     ]
 });