Chore: Enable comma-dangle on ESLint codebase (fixes #7725) (#7906)

eslint · Jan 12, 2017 · d6150e3 · d6150e3
1 parent 075ec25
commit d6150e3
Show file tree

Hide file tree

Showing 63 changed files with 259 additions and 258 deletions.
diff --git a/lib/ast-utils.js b/lib/ast-utils.js
@@ -1037,7 +1037,7 @@ module.exports = {
 
         return {
             start: Object.assign({}, start),
-            end: Object.assign({}, end),
+            end: Object.assign({}, end)
         };
     },
 

diff --git a/lib/config/config-initializer.js b/lib/config/config-initializer.js
@@ -317,7 +317,7 @@ function promptUser(callback) {
             default: false,
             when(answers) {
                 return answers.styleguide === "airbnb";
-            },
+            }
         },
         {
             type: "input",

diff --git a/lib/formatters/codeframe.js b/lib/formatters/codeframe.js
@@ -56,7 +56,7 @@ function formatMessage(message, parentResult) {
         `${type}:`,
         `${msg}`,
         ruleId ? `${ruleId}` : "",
-        sourceCode ? `at ${filePath}:` : `at ${filePath}`,
+        sourceCode ? `at ${filePath}:` : `at ${filePath}`
     ].filter(String).join(" ");
 
     const result = [firstLine];

diff --git a/lib/internal-rules/internal-consistent-docs-description.js b/lib/internal-rules/internal-consistent-docs-description.js
@@ -71,7 +71,7 @@ function checkMetaDocsDescription(context, exportsNode) {
     if (description === "") {
         context.report({
             node: metaDocsDescription.value,
-            message: "`meta.docs.description` should not be empty.",
+            message: "`meta.docs.description` should not be empty."
         });
         return;
     }

diff --git a/lib/rules/comma-dangle.js b/lib/rules/comma-dangle.js
@@ -20,7 +20,7 @@ const DEFAULT_OPTIONS = Object.freeze({
     objects: "never",
     imports: "never",
     exports: "never",
-    functions: "ignore",
+    functions: "ignore"
 });
 
 /**
@@ -53,7 +53,7 @@ function normalizeOptions(optionValue) {
             exports: optionValue,
 
             // For backward compatibility, always ignore functions.
-            functions: "ignore",
+            functions: "ignore"
         };
     }
     if (typeof optionValue === "object" && optionValue !== null) {
@@ -62,7 +62,7 @@ function normalizeOptions(optionValue) {
             objects: optionValue.objects || DEFAULT_OPTIONS.objects,
             imports: optionValue.imports || DEFAULT_OPTIONS.imports,
             exports: optionValue.exports || DEFAULT_OPTIONS.exports,
-            functions: optionValue.functions || DEFAULT_OPTIONS.functions,
+            functions: optionValue.functions || DEFAULT_OPTIONS.functions
         };
     }
 
@@ -121,7 +121,7 @@ module.exports = {
                         additionalProperties: false
                     }
                 ]
-            },
+            }
         ]
     },
 
@@ -312,7 +312,7 @@ module.exports = {
             "always-multiline": forceTrailingCommaIfMultiline,
             "only-multiline": allowTrailingCommaIfMultiline,
             never: forbidTrailingComma,
-            ignore: lodash.noop,
+            ignore: lodash.noop
         };
 
         return {
@@ -330,7 +330,7 @@ module.exports = {
             FunctionExpression: predicate[options.functions],
             ArrowFunctionExpression: predicate[options.functions],
             CallExpression: predicate[options.functions],
-            NewExpression: predicate[options.functions],
+            NewExpression: predicate[options.functions]
         };
     }
 };
diff --git a/lib/rules/comma-style.js b/lib/rules/comma-style.js
@@ -48,7 +48,7 @@ module.exports = {
             FunctionDeclaration: true,
             FunctionExpression: true,
             ImportDeclaration: true,
-            ObjectPattern: true,
+            ObjectPattern: true
         };
 
         if (context.options.length === 2 && context.options[1].hasOwnProperty("exceptions")) {

diff --git a/lib/rules/lines-around-directive.js b/lib/rules/lines-around-directive.js
@@ -31,7 +31,7 @@ module.exports = {
                         },
                         after: {
                             enum: ["always", "never"]
-                        },
+                        }
                     },
                     additionalProperties: false,
                     minProperties: 2

diff --git a/lib/rules/max-lines.js b/lib/rules/max-lines.js
@@ -134,7 +134,7 @@ module.exports = {
                         message: "File must be at most {{max}} lines long. It's {{actual}} lines long.",
                         data: {
                             max,
-                            actual: lines.length,
+                            actual: lines.length
                         }
                     });
                 }

diff --git a/lib/rules/max-statements-per-line.js b/lib/rules/max-statements-per-line.js
@@ -60,7 +60,7 @@ module.exports = {
                     data: {
                         numberOfStatementsOnThisLine,
                         maxStatementsPerLine,
-                        statements: numberOfStatementsOnThisLine === 1 ? "statement" : "statements",
+                        statements: numberOfStatementsOnThisLine === 1 ? "statement" : "statements"
                     }
                 });
             }

diff --git a/lib/rules/no-await-in-loop.js b/lib/rules/no-await-in-loop.js
@@ -10,25 +10,25 @@ const loopTypes = new Set([
     "ForOfStatement",
     "ForInStatement",
     "WhileStatement",
-    "DoWhileStatement",
+    "DoWhileStatement"
 ]);
 
 // Node types at which we should stop looking for loops. For example, it is fine to declare an async
 // function within a loop, and use await inside of that.
 const boundaryTypes = new Set([
     "FunctionDeclaration",
     "FunctionExpression",
-    "ArrowFunctionExpression",
+    "ArrowFunctionExpression"
 ]);
 
 module.exports = {
     meta: {
         docs: {
             description: "disallow `await` inside of loops",
             category: "Possible Errors",
-            recommended: false,
+            recommended: false
         },
-        schema: [],
+        schema: []
     },
     create(context) {
         return {
@@ -69,7 +69,7 @@ module.exports = {
                         }
                     }
                 }
-            },
+            }
         };
     }
 };
diff --git a/lib/rules/no-dupe-keys.js b/lib/rules/no-dupe-keys.js
@@ -123,7 +123,7 @@ module.exports = {
                         node: info.node,
                         loc: node.key.loc,
                         message: "Duplicate key '{{name}}'.",
-                        data: { name },
+                        data: { name }
                     });
                 }
 

diff --git a/lib/rules/no-return-await.js b/lib/rules/no-return-await.js
@@ -35,7 +35,7 @@ module.exports = {
             context.report({
                 node: context.getSourceCode().getFirstToken(node),
                 loc: node.loc,
-                message,
+                message
             });
         }
 
@@ -88,7 +88,7 @@ module.exports = {
                 if (isInTailCallPosition(node) && !hasErrorHandler(node)) {
                     reportUnnecessaryAwait(node);
                 }
-            },
+            }
         };
     }
 };
diff --git a/lib/rules/no-useless-return.js b/lib/rules/no-useless-return.js
@@ -213,7 +213,7 @@ module.exports = {
                 scopeInfo = {
                     upper: scopeInfo,
                     uselessReturns: [],
-                    codePath,
+                    codePath
                 };
             },
 
@@ -226,7 +226,7 @@ module.exports = {
                         message: "Unnecessary return statement.",
                         fix(fixer) {
                             return isRemovable(node) ? fixer.remove(node) : null;
-                        },
+                        }
                     });
                 }
 
@@ -238,7 +238,7 @@ module.exports = {
             onCodePathSegmentStart(segment) {
                 const info = {
                     uselessReturns: getUselessReturns([], segment.allPrevSegments),
-                    returned: false,
+                    returned: false
                 };
 
                 // Stores the info.
@@ -287,7 +287,7 @@ module.exports = {
             WithStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
             ExportNamedDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
             ExportDefaultDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
-            ExportAllDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
+            ExportAllDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed
         };
     }
 };
diff --git a/lib/rules/quotes.js b/lib/rules/quotes.js
@@ -269,7 +269,7 @@ module.exports = {
                         node,
                         message: "Strings must use {{description}}.",
                         data: {
-                            description: settings.description,
+                            description: settings.description
                         },
                         fix(fixer) {
                             if (isPartOfDirectivePrologue(node)) {

diff --git a/lib/rules/require-await.js b/lib/rules/require-await.js
@@ -51,7 +51,7 @@ module.exports = {
         function enterFunction() {
             scopeInfo = {
                 upper: scopeInfo,
-                hasAwait: false,
+                hasAwait: false
             };
         }
 

diff --git a/lib/rules/sort-keys.js b/lib/rules/sort-keys.js
@@ -64,7 +64,7 @@ const isValidOrders = {
     },
     descIN(a, b) {
         return isValidOrders.ascIN(b, a);
-    },
+    }
 };
 
 //------------------------------------------------------------------------------
@@ -147,7 +147,7 @@ module.exports = {
                             prevName,
                             order,
                             insensitive: insensitive ? "insensitive " : "",
-                            natual: natual ? "natural " : "",
+                            natual: natual ? "natural " : ""
                         }
                     });
                 }

diff --git a/lib/rules/space-before-function-paren.js b/lib/rules/space-before-function-paren.js
@@ -159,7 +159,7 @@ module.exports = {
         return {
             FunctionDeclaration: validateSpacingBeforeParentheses,
             FunctionExpression: validateSpacingBeforeParentheses,
-            ArrowFunctionExpression: validateSpacingBeforeParentheses,
+            ArrowFunctionExpression: validateSpacingBeforeParentheses
         };
     }
 };
diff --git a/lib/testers/rule-tester.js b/lib/testers/rule-tester.js
@@ -213,7 +213,7 @@ Object.defineProperties(RuleTester, {
             RuleTester[DESCRIBE] = value;
         },
         configurable: true,
-        enumerable: true,
+        enumerable: true
     },
     it: {
         get() {
@@ -226,8 +226,8 @@ Object.defineProperties(RuleTester, {
             RuleTester[IT] = value;
         },
         configurable: true,
-        enumerable: true,
-    },
+        enumerable: true
+    }
 });
 
 RuleTester.prototype = {

diff --git a/lib/util/glob-util.js b/lib/util/glob-util.js
@@ -165,7 +165,7 @@ function listFilesToProcess(globPatterns, options) {
             const globOptions = {
                 nodir: true,
                 dot: true,
-                cwd,
+                cwd
             };
 
             new GlobSync(pattern, globOptions, shouldIgnore).found.forEach(globMatch => {

diff --git a/packages/eslint-config-eslint/default.yml b/packages/eslint-config-eslint/default.yml
@@ -13,6 +13,7 @@ rules:
     camelcase: ["error", { properties: "never" }]
     callback-return: ["error", ["cb", "callback", "next"]]
     class-methods-use-this: "error"
+    comma-dangle: "error"
     comma-spacing: "error"
     comma-style: ["error", "last"]
     consistent-return: "error"

diff --git a/tests/lib/ast-utils.js b/tests/lib/ast-utils.js
@@ -759,7 +759,7 @@ describe("ast-utils", () => {
             "class A { static *foo() {} }": "static generator method 'foo'",
             "class A { static async foo() {} }": "static async method 'foo'",
             "class A { static get foo() {} }": "static getter 'foo'",
-            "class A { static set foo(a) {} }": "static setter 'foo'",
+            "class A { static set foo(a) {} }": "static setter 'foo'"
         };
 
         Object.keys(expectedResults).forEach(key => {
@@ -832,7 +832,7 @@ describe("ast-utils", () => {
             "class A { static *foo() {} }": [10, 21],
             "class A { static async foo() {} }": [10, 26],
             "class A { static get foo() {} }": [10, 24],
-            "class A { static set foo(a) {} }": [10, 24],
+            "class A { static set foo(a) {} }": [10, 24]
         };
 
         Object.keys(expectedResults).forEach(key => {
@@ -877,7 +877,7 @@ describe("ast-utils", () => {
         const expectedResults = {
             "{}": true,
             "{ a }": false,
-            a: false,
+            a: false
         };
 
         Object.keys(expectedResults).forEach(key => {
@@ -895,7 +895,7 @@ describe("ast-utils", () => {
             "(function foo() { a })": false,
             "(a) => {}": true,
             "(a) => { a }": false,
-            "(a) => a": false,
+            "(a) => a": false
         };
 
         Object.keys(expectedResults).forEach(key => {

diff --git a/tests/lib/formatters/codeframe.js b/tests/lib/formatters/codeframe.js
@@ -146,7 +146,7 @@ describe("formatter:codeframe", () => {
                 line: 1,
                 column: 7,
                 ruleId: "no-unused-vars"
-            }],
+            }]
         }];
 
         it("should return a string with multiple entries", () => {