Skip to content

Commit

Permalink
++ or -- in the token before is not always safe.
Browse files Browse the repository at this point in the history
  • Loading branch information
Rec0iL99 committed Nov 17, 2023
1 parent f4e4d9a commit e12d3bc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
4 changes: 1 addition & 3 deletions lib/rules/no-console.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,7 @@ module.exports = {
tokenAfter.value !== "++" &&
tokenAfter.value !== "--" &&
Boolean(tokenBefore) &&
!SAFE_TOKENS_BEFORE.test(tokenBefore.value) &&
tokenBefore.value !== "++" &&
tokenBefore.value !== "--"
!SAFE_TOKENS_BEFORE.test(tokenBefore.value)
);
}

Expand Down
9 changes: 9 additions & 0 deletions tests/lib/rules/no-console.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,15 @@ ruleTester.run("no-console", rule, {
suggestions: null
}]
},
{
code: "a++\nconsole.log();\n/b/",
parserOptions: { ecmaVersion: "latest" },
errors: [{
messageId: "unexpected",
type: "MemberExpression",
suggestions: null
}]
},
{
code: "a();\nconsole.log(foo);\n[1, 2, 3].forEach(a => doSomething(a));",
parserOptions: { ecmaVersion: "latest" },
Expand Down

0 comments on commit e12d3bc

Please sign in to comment.