Merge pull request #5458 from captbaritone/issue5456

Update: Replace getLast() with lodash.last() (fixes #5456)

docs/developer-guide/code-path-analysis.md

@@ -198,7 +198,7 @@ bar();
 ### To check whether or not this is reachable
 
 ```js
-var getLast = require("../ast-utils").getLast;
+var last = require("lodash").last;
 
 function isReachable(segment) {
     return segment.reachable;
@@ -218,7 +218,7 @@ module.exports = function(context) {
 
         // Checks reachable or not.
         "ExpressionStatement": function(node) {
-            var codePath = getLast(codePathStack);
+            var codePath = last(codePathStack);
 
             // Checks the current code path segments.
             if (!codePath.currentSegments.some(isReachable)) {
@@ -242,7 +242,7 @@ So a rule must not modify those instances.
 Please use a map of information instead.
 
 ```js
-var getLast = require("../ast-utils").getLast;
+var last = require("lodash").last;
 
 function hasCb(node, context) {
     if (node.type.indexOf("Function") !== -1) {
@@ -289,7 +289,7 @@ module.exports = function(context) {
         // Manages state of code paths.
         "onCodePathSegmentStart": function(segment) {
             // Ignores if `cb` doesn't exist.
-            if (!getLast(funcInfoStack).hasCb) {
+            if (!last(funcInfoStack).hasCb) {
                 return;
             }
 
@@ -307,7 +307,7 @@ module.exports = function(context) {
 
         // Checks reachable or not.
         "CallExpression": function(node) {
-            var funcInfo = getLast(funcInfoStack);
+            var funcInfo = last(funcInfoStack);
 
             // Ignores if `cb` doesn't exist.
             if (!funcInfo.hasCb) {

lib/rules/comma-dangle.js

@@ -10,21 +10,10 @@
 "use strict";
 
 //------------------------------------------------------------------------------
-// Helpers
+// Requirements
 //------------------------------------------------------------------------------
 
-/**
- * Gets the last element of a given array.
- *
- * @param {*[]} xs - An array to get.
- * @returns {*} The last element, or undefined.
- */
-function getLast(xs) {
-    if (xs.length === 0) {
-        return null;
-    }
-    return xs[xs.length - 1];
-}
+var lodash = require("lodash");
 
 /**
  * Checks whether or not a trailing comma is allowed in a given node.
@@ -74,7 +63,7 @@ module.exports = function(context) {
      * @returns {boolean} `true` if the node is multiline.
      */
     function isMultiline(node) {
-        var lastItem = getLast(node.properties || node.elements || node.specifiers);
+        var lastItem = lodash.last(node.properties || node.elements || node.specifiers);
         if (!lastItem) {
             return false;
         }
@@ -106,7 +95,7 @@ module.exports = function(context) {
      * @returns {void}
      */
     function forbidTrailingComma(node) {
-        var lastItem = getLast(node.properties || node.elements || node.specifiers);
+        var lastItem = lodash.last(node.properties || node.elements || node.specifiers);
         if (!lastItem || (node.type === "ImportDeclaration" && lastItem.type !== "ImportSpecifier")) {
             return;
         }
@@ -142,7 +131,7 @@ module.exports = function(context) {
      * @returns {void}
      */
     function forceTrailingComma(node) {
-        var lastItem = getLast(node.properties || node.elements || node.specifiers);
+        var lastItem = lodash.last(node.properties || node.elements || node.specifiers);
         if (!lastItem || (node.type === "ImportDeclaration" && lastItem.type !== "ImportSpecifier")) {
             return;
         }

lib/rules/no-fallthrough.js

@@ -8,7 +8,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-var getLast = require("../util").getLast;
+var lodash = require("lodash");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -24,7 +24,7 @@ var FALLTHROUGH_COMMENT = /falls?\s?through/i;
  */
 function hasFallthroughComment(node, context) {
     var sourceCode = context.getSourceCode();
-    var comment = getLast(sourceCode.getComments(node).leading);
+    var comment = lodash.last(sourceCode.getComments(node).leading);
 
     return Boolean(comment && FALLTHROUGH_COMMENT.test(comment.value));
 }
@@ -76,7 +76,7 @@ module.exports = function(context) {
             // And allows empty cases and the last case.
             if (currentCodePath.currentSegments.some(isReachable) &&
                 node.consequent.length > 0 &&
-                getLast(node.parent.cases) !== node
+                lodash.last(node.parent.cases) !== node
             ) {
                 fallthroughCase = node;
             }