.eslintignore does not filter hidden files

[puzrin]

/node_modules/**
**/node_modules/**

I still get errors for node_modules/less/.grunt/grunt-contrib-jasmine/boot.js and similar. Other files from node-modules folder are ignored ok.

[puzrin]

I've managed to filter those files with this kludge: **/.*/**

[jonvuri]

We could fix this (if we want) by setting the "dot" option on minimatch.

[puzrin]

I think, it's a bug.

Also, ignoring dot folders is a good way to get some speed, because .git folders scan with many files can be skipped.

[jonvuri]

Whether we ignore dot folders or not is a separate issue - minimatch needs to treat them however our traversal treats them. If anything it should be less restrictive.

[nzakas]

I think we should just make sure the traversal skips them.

[puzrin]

Hm... is it a good idea to hardcode skipping .XXX files ? Not sure.

IMHO, it's better to make ingnores work exactly as in other popular programs, instead of doing something custom.

[jonvuri]

IMHO, it's better to make ingnores work exactly as in other popular programs, instead of doing something custom.

In this case, our closest precedent is jshint, which also ignores dot files.

[nzakas]

@puzrin I thought you were saying we should always ignore dot files and directories because that's the way other programs work?

[puzrin]

@nzakas i meaned opposite - no reasons to ignore by default. May be, i didn't understood right your previous answer.

@jrajav I didn't knew it. Seriously. Meaned git, npm and so on. Jshint is "better than nothing", but i'm not sure it worth copy everything from it.

[jonvuri]

The difference is that git and npm manage files and directories in general. It makes sense for them to preserve everything with few questions asked. On the other hand, JSHint and ESLint are specialized tools - they act on JavaScript source code, and can be a lot more selective about what files they'll see during implicit directory traversal. It makes sense to ignore dot files and dot directories when they're not passed explicitly, because normally those are not a part of the primary source code but only accessory to it.

[puzrin]

We can't be sure, what is primary and what is not. Anyway, i think, the root of problem is that scan/ignore alrogythm is reinvented from scratch, and minimatch is low-level library, that does not the same that expected to be done in ignore patterns.

[nzakas]

Let's not overcomplicate the problem. JSHint ignores dot-directories (it basically does an ls of each directory). If people expect something different from ESLint, then we are probably doing something wrong. I'm fine with switching to always ignore.

[puzrin]

No problem, i'll be fine with any kind of fix.