Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify option "multiline" for object-curly-newline #11634

Closed
golopot opened this issue Apr 19, 2019 · 3 comments

Comments

@golopot
Copy link
Contributor

commented Apr 19, 2019

The problem you want to solve.
The docs for option multiline for object-curly-newline failed to mention that when the contained properties is single line, line breaks are disallowed.

Your take on the correct solution to problem.

- "multiline": true requires line breaks if there are line breaks inside properties or between properties
+ "multiline": true requires line breaks if there are line breaks inside properties or between properties. Otherwise, it disallows line breaks.

The same issue holds for array-bracket-newline.
Are you willing to submit a pull request to implement this change?
Yes.

@golopot golopot changed the title Clarify option "multiline" for object-curly-newline Docs: Clarify option "multiline" for object-curly-newline Apr 19, 2019

@platinumazure

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Hi @golopot, thanks for the issue.

This is just a documentation change to existing behavior, so I don't think we need to evaluate this as an enhancement proposal. I've marked this issue as accepted. Please feel free to submit a pull request at your convenience. Thanks!

@eslint eslint bot closed this Jul 19, 2019

@eslint eslint bot added the auto closed label Jul 19, 2019

@eslint

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that accepted issues failing to be implemented after 90 days tend to
never be implemented, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@kaicataldo

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Reopening since this is an accepted documentation change.

@kaicataldo kaicataldo reopened this Jul 19, 2019

golopot added a commit to golopot/eslint that referenced this issue Jul 20, 2019

platinumazure added a commit that referenced this issue Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.