Error when there's a \r in .eslintrc

[gyandeeps]

One of the test case failed on my machine. I just forked the repo and it failed.

The test case is:

var filepath = path.resolve(__dirname, "..", "fixtures", ".eslintignore2");
it("should return true for file matching a child of an ignore pattern", function() {
    var ignoredPaths = IgnoredPaths.load({ ignore: true, ignorePath: filepath });
    assert.ok(ignoredPaths.contains("undef.js/subdir/grandsubdir"));
});

The content of eslintignore2 is:

undef.js

Am I doing something wrong or is it a problem?

UPDATE
I think the eslintignore2 file has 2 rows. second row is empty. Thats why it fails.
I used notepad++ to open the file.
Can any one confirm this on windows 7 machine?

Also after split("\n") operation is done on the file content it gives an array like this

[ 'undef.js\r' , '' ]

Also after doing filter(nonEmpty) on it, it refines the array to be like this

[ 'undef.js\r' ]

The above split and filter is done here: https://github.com/eslint/eslint/blob/master/lib/ignored-paths.js#L44

I think the mystery is \r thing.
http://stackoverflow.com/questions/1279779/what-is-the-difference-between-r-and-n

Discussions around this area within eslint:

• Breaking: Ignore children of all patterns by adding "/**" #1082
• Make .eslintignore almost exact as .gitignore #1091

[nzakas]

This looks like we just need to split on /\r?\n/ instead of just "\n".

[gyandeeps]

will have fix with PR ready in few.
Thanks

[michaelficarra]

How did a failing test get on master?

[gyandeeps]

I think it only happens on windows machine. Travis build never failed.
For more info http://stackoverflow.com/questions/1279779/what-is-the-difference-between-r-and-n

[nzakas]

The test isn't failing on master. I'm also on windows 7 and have no problem.

@gyandeeps you should double check that git isn't automatically adding windows-style line endings on your machine.

[gyandeeps]

@nzakas You are correct. It has something to do with my git config.
I tried it on my friends machine and none of the test failed.
Do you think i should close this issue and the PR #1174

[nzakas]

No, I think this is a legitimate issue where we will be handling Windows-escaped files incorrectly. That should be fixed.

[gyandeeps]

Any idea how I can make a file to have windows style escape and then create test against it. I will have to save that file inside test. How can i force a file to have \r escapes in it?
Any help would be appreciated. Thanks.

[michaelficarra]

https://en.wikipedia.org/wiki/Unix2dos

[nzakas]

Commit message format error left this issue open, but this has been fixed.