Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vars-on-top conflicts with 'use strict' #1235

Closed
lo1tuma opened this issue Sep 9, 2014 · 2 comments · Fixed by #1236
Closed

vars-on-top conflicts with 'use strict' #1235

lo1tuma opened this issue Sep 9, 2014 · 2 comments · Fixed by #1236
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@lo1tuma
Copy link
Member

lo1tuma commented Sep 9, 2014

There is a failing test-case for vars-on-top which I think should be valid:

"use strict";
var first = 0;
function foo() {
    first = 2;
}
@lo1tuma lo1tuma changed the title vars-on-top conflicts with a global 'use strict' vars-on-top conflicts with 'use strict' Sep 9, 2014
@lo1tuma
Copy link
Member Author

lo1tuma commented Sep 9, 2014

Also the following test-case fails:

function foo() {
    "use strict";
    var first = 0;
}

@michaelficarra
Copy link
Member

Working on this.

michaelficarra added a commit to michaelficarra/eslint that referenced this issue Sep 9, 2014
@michaelficarra
Fix: vars-on-top directive support (fixes eslint#1235)
da64a37
@michaelficarra michaelficarra mentioned this issue Sep 9, 2014
Merged
@nzakas nzakas added bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Sep 9, 2014
nzakas added a commit that referenced this issue Sep 9, 2014
@nzakas
Merge pull request #1236 from michaelficarra/GH-1235
e1f436d 
Fix: vars-on-top directive support (fixes #1235)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: vars-on-top directive support (fixes #1235) michaelficarra/eslint
3 participants
@nzakas @lo1tuma @michaelficarra