Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #1251

Closed
lo1tuma opened this issue Sep 11, 2014 · 5 comments
Closed

Upgrade dependencies #1251

lo1tuma opened this issue Sep 11, 2014 · 5 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint

Comments

@lo1tuma
Copy link
Member

lo1tuma commented Sep 11, 2014

I measured a performance improvement after upgrading all dependencies.

Before:

CPU Speed is 1700 with multiplier 7500000
Performance Run #1:  1175.168792ms
Performance Run #2:  1163.212699ms
Performance Run #3:  1148.925926ms
Performance Run #4:  1150.3985010000001ms
Performance Run #5:  1168.486074ms
Performance budget ok:  1163.212699ms (limit: 4411.764705882353ms)

After:

CPU Speed is 1700 with multiplier 7500000
Performance Run #1:  1052.640642ms
Performance Run #2:  1070.506447ms
Performance Run #3:  1064.59042ms
Performance Run #4:  1070.372476ms
Performance Run #5:  1080.126198ms
Performance budget ok:  1070.372476ms (limit: 4411.764705882353ms)
@nzakas nzakas added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint labels Sep 11, 2014
@nzakas
Copy link
Member

nzakas commented Sep 11, 2014

Did all tests pass as well?

@michaelficarra
Copy link
Member

@nzakas it's possible that different versions of dependencies was a reason you weren't experiencing the performance improvements that everyone else saw.

@lo1tuma
Copy link
Member Author

lo1tuma commented Sep 11, 2014

One test of the stylish formatter fails because of the upgrade to the latest chalk version. But it is easy to fix (see #1256).

@nzakas
Copy link
Member

nzakas commented Sep 11, 2014

@michaelficarra hmm, good point. Maybe we should be shrinkwrapping dependencies?

@lo1tuma
Copy link
Member Author

lo1tuma commented Sep 12, 2014

It seems the performance improvements were made in chalk.

@nzakas nzakas closed this as completed in e833c41 Sep 12, 2014
nzakas added a commit that referenced this issue Sep 12, 2014
Upgrade: upgrade outdated dependencies (fixes #1251)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
None yet
Development

No branches or pull requests

3 participants