Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disable issues with comments #12548

Closed
OmgImAlexis opened this issue Nov 8, 2019 · 9 comments
Closed

No way to disable issues with comments #12548

OmgImAlexis opened this issue Nov 8, 2019 · 9 comments
Labels
3rd party plugin This is an issue related to a 3rd party plugin, config, or parser archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules

Comments

@OmgImAlexis
Copy link
Contributor

Tell us about your environment

  • ESLint Version: N/A
  • Node Version: v12.5.0
  • npm Version: 6.13.0

What parser (default, Babel-ESLint, etc.) are you using?
Default with xo.
Please show your full configuration:

Configuration

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

// eslint-disable-next-line capitalized-comments
/* spell-checker: disable */
xo --quiet

What did you expect to happen?
capitalized-comments to apply to the comment below it.

What actually happened? Please include the actual, raw output from ESLint.

  ✖  131:31  capitalized-comments rule is disabled but never reported.  eslint-comments/no-unused-disable

If I remove the eslint-disable-next-line line then I get this.

  ✖  131:31   Comments should not begin with a lowercase character.      capitalized-comments

Are you willing to submit a pull request to fix this bug?
Possibly?

@OmgImAlexis OmgImAlexis added bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon labels Nov 8, 2019
@g-plane g-plane added question This issue asks a question about ESLint and removed bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon labels Nov 8, 2019
@g-plane
Copy link
Member

g-plane commented Nov 8, 2019

Thanks for this issue.

It seems that you've added an additional comment after eslint-disable-next-line. If you will want to keep that comment (about spell checker), you can consider adding eslint-disable-line at the same line which ESLint reports.

@OmgImAlexis
Copy link
Contributor Author

The issue it has is the spell check comment though? That’s why I opened this. I had assumed the eslint comment would apply for the spelling comment but it doesn’t seem to work.

@g-plane
Copy link
Member

g-plane commented Nov 8, 2019

Oh sorry. I didn't realize that.

@g-plane g-plane added bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed question This issue asks a question about ESLint labels Nov 8, 2019
@thewalla07
Copy link
Contributor

Hi, this may not be related to ESLint directly, but rather with the eslint-plugin-eslint-comments dependency used by xo. This dependency is the one that actually reports this error in xo

@kaicataldo kaicataldo added the 3rd party plugin This is an issue related to a 3rd party plugin, config, or parser label Nov 9, 2019
thewalla07 added a commit to thewalla07/eslint-plugin-eslint-comments that referenced this issue Nov 10, 2019
Adding a test to verify if this rule is working for
capitalized-comments. I could not replicate the issue locally on linux
where earlier in the week I could on windows.

Refs mysticatea#34 and eslint/eslint#12548
thewalla07 added a commit to thewalla07/xo that referenced this issue Nov 10, 2019
Trying to reproduce an issue with disabling capitalized-comments rules.
This could not be reproduced locally in linux, but I could earlier in
the week on windows. Testing to see if this breaks in CI for the xo
plugin.

Refs eslint/eslint#12548
Refs mysticatea/eslint-plugin-eslint-comments#34
@thewalla07
Copy link
Contributor

@OmgImAlexis can you give some more information on your environment and any configs you have for xo or ESLint in your project? I am struggling to reproduce this again

@OmgImAlexis
Copy link
Contributor Author

I’m using a default install of xo.

I’m seeing this 100% of the time on my project so if there’s anything you need me to test just let me know.

@OmgImAlexis
Copy link
Contributor Author

I noticed you talked about Linux and windows. I’m on macOS, doubt that’s makes a difference but figured I’d mention it.

@kaicataldo
Copy link
Member

@OmgImAlexis Is there any chance you could make a minimal reproduction case repo? It's tough to know what's going on with all the moving parts at the moment.

@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Dec 12, 2019
@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 11, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3rd party plugin This is an issue related to a 3rd party plugin, config, or parser archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

4 participants