-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No way to disable issues with comments #12548
Comments
Thanks for this issue. It seems that you've added an additional comment after |
The issue it has is the spell check comment though? That’s why I opened this. I had assumed the eslint comment would apply for the spelling comment but it doesn’t seem to work. |
Oh sorry. I didn't realize that. |
Hi, this may not be related to ESLint directly, but rather with the eslint-plugin-eslint-comments dependency used by xo. This dependency is the one that actually reports this error in xo |
Adding a test to verify if this rule is working for capitalized-comments. I could not replicate the issue locally on linux where earlier in the week I could on windows. Refs mysticatea#34 and eslint/eslint#12548
Trying to reproduce an issue with disabling capitalized-comments rules. This could not be reproduced locally in linux, but I could earlier in the week on windows. Testing to see if this breaks in CI for the xo plugin. Refs eslint/eslint#12548 Refs mysticatea/eslint-plugin-eslint-comments#34
@OmgImAlexis can you give some more information on your environment and any configs you have for xo or ESLint in your project? I am struggling to reproduce this again |
I’m using a default install of xo. I’m seeing this 100% of the time on my project so if there’s anything you need me to test just let me know. |
I noticed you talked about Linux and windows. I’m on macOS, doubt that’s makes a difference but figured I’d mention it. |
@OmgImAlexis Is there any chance you could make a minimal reproduction case repo? It's tough to know what's going on with all the moving parts at the moment. |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
Default with
xo
.Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
What did you expect to happen?
capitalized-comments
to apply to the comment below it.What actually happened? Please include the actual, raw output from ESLint.
If I remove the
eslint-disable-next-line
line then I get this.Are you willing to submit a pull request to fix this bug?
Possibly?
The text was updated successfully, but these errors were encountered: