Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request/discussion: add color to codeframe formatter #14870

Closed
elektronik2k5 opened this issue Aug 2, 2021 · 1 comment
Closed

Feature request/discussion: add color to codeframe formatter #14870

elektronik2k5 opened this issue Aug 2, 2021 · 1 comment
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon
Projects

Comments

@elektronik2k5
Copy link

elektronik2k5 commented Aug 2, 2021

Hello and thanks for writing and maintaining eslint!

I was wondering whether there's any reason why the codeframe formatter output is always monochromatic. Is there any reason we shouldn't enable syntax highlighting?

The version of ESLint you are using.
7.31.0

The problem you want to solve.
codeframe formatter output is monochromatic even in color capable TTYs.

Your take on the correct solution to problem.
Enable colors by setting the highlightCode option to true. I believe that'll handle everything automatically. If we wanna be more pedantic and consistent then we can respect eslint's --color/--no-color CLI arguments.

Are you willing to submit a pull request to implement this change?
Yes, definitely! :)

Tagging original contributor @vitorbal for historical context.

@elektronik2k5 elektronik2k5 added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon labels Aug 2, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Aug 2, 2021
@nzakas
Copy link
Member

nzakas commented Aug 2, 2021

The codeframe formatter is being removed in v8.0.0, so we aren't making any further changes to it.

@nzakas nzakas closed this as completed Aug 2, 2021
Triage automation moved this from Needs Triage to Complete Aug 2, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 30, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

2 participants