Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Anchor link missing on headers #16128

Closed
1 task
bmish opened this issue Jul 13, 2022 · 3 comments · Fixed by #16134 or eslint/eslint.org#271
Closed
1 task

Bug: Anchor link missing on headers #16128

bmish opened this issue Jul 13, 2022 · 3 comments · Fixed by #16134 or eslint/eslint.org#271
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects

Comments

@bmish
Copy link
Sponsor Member

bmish commented Jul 13, 2022

URL(s)

Any page on the new ESLint website. Example: https://eslint.org/docs/latest/developer-guide/working-with-rules

What did you do?

Hover over section header. For example, the "Rule Basics" section header.

What did you expect to happen?

An anchor link icon to appear that can be used to directly link to a particular header inside a page. The direct section link https://eslint.org/docs/latest/developer-guide/working-with-rules#rule-basics can only be found in the table of contents now.

What actually happened?

Nothing.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

From my memory, this feature was present on the old website, but is missing on the new website. It is also a standard convenience feature on GitHub markdown pages and many other documentation sites.

@bmish bmish added the bug ESLint is working incorrectly label Jul 13, 2022
@nzakas
Copy link
Member

nzakas commented Jul 14, 2022

Yes, I think it’s just an oversight. Moving this to the eslint repo where the docs site lives.

For reference, the old site is now at https://archive.eslint.org

@nzakas nzakas transferred this issue from eslint/eslint.org Jul 14, 2022
@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Jul 14, 2022
@nzakas nzakas added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed bug ESLint is working incorrectly labels Jul 14, 2022
@harish-sethuraman
Copy link
Member

I believe we were using https://www.npmjs.com/package/anchor-js to add anchors to the heading elements in the archive website. If we want to do the same i'm up for grabs to change it in all docs site :)

@nzakas
Copy link
Member

nzakas commented Jul 14, 2022

@harish-sethuraman yes, please go ahead. 🙏

Triage automation moved this from Ready to Implement to Complete Jul 20, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 17, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
Archived in project
Triage
Complete
3 participants