docs: add anchors for blogs #271
Conversation
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for cn-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for looking at this. Because this is only targeting blog posts, could all of the changes be made to layouts/post.html instead? That way everything that is post-specific is in one file. |
eslint-github-bot
bot
added
the
documentation
|
bump for review |
src/assets/js/main.js
Outdated
| @@ -89,3 +89,7 @@ | |||
| }); | |||
| } | |||
| })(); | |||
|
|
|||
| document.addEventListener("DOMContentLoaded", () => { | |||
There was a problem hiding this comment.
Can you also move this into post.html as an inline script? This causes an error on non-blog post pages now.
|
@harish-sethuraman please don't bump for review. :) I already get notifications when pull requests are updated. If for some reason you don't get a response after a week, then it's appropriate to ask again. |
|
Thanks. Just a note: in this repo, we don’t prefix everything with “docs:”, that’s just in the eslint repo. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
Fixes eslint/eslint#16128
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added anchor-js library and add anchors for headings inside docs
Is there anything you'd like reviewers to focus on?
check if any other element is getting anchors. I verified that table of content was h2 and was getting the anchor so I've move it to be a paragraph text and added font-weight alone to match the styling. If you are aware of any other elements like that need help. I verified once 😅 and everything seems to work fine