feat!: Switch Linter to flat config by default #17851
Conversation
eslint-github-bot
bot
added
breaking
✅ Deploy Preview for docs-eslint canceled.
|
| @@ -23,7 +23,7 @@ describe("eslint-fuzzer", function() { | |||
| */ | |||
| this.timeout(15000); // eslint-disable-line no-invalid-this -- Mocha timeout | |||
|
|
|||
| const linter = new eslint.Linter(); | |||
| const linter = new eslint.Linter({ configType: "eslintrc" }); | |||
There was a problem hiding this comment.
When we remove eslintrc mode, we'll need to revisit how the fuzzer works.
| @@ -17505,32 +17505,6 @@ var a = "test2"; | |||
| }); | |||
| }); | |||
|
|
|||
| describe("Mutability", () => { | |||
There was a problem hiding this comment.
Not sure why these are still here. There's no way to test this using flat config.
| @@ -498,7 +498,7 @@ class RuleTester { | |||
| * @type {Object} | |||
| */ | |||
| this.rules = {}; | |||
| this.linter = new Linter(); | |||
| this.linter = new Linter({ configType: "eslintrc" }); | |||
There was a problem hiding this comment.
Temporary measure until we remove RuleTester
nzakas
force-pushed
the
flat-config-linter
branch
from
bfcd4e6
to
5ed8e25
Compare
nzakas
force-pushed
the
flat-config-linter
branch
from
f677357
to
e163306
Compare
| */ | ||
| constructor({ cwd, configType } = {}) { | ||
| constructor({ cwd, configType = "flat" } = {}) { |
There was a problem hiding this comment.
When config argument is not passed to verify/verifyAndFix, Linter still runs eslintrc code paths, which is probably not what we want if "flat" is the new default.
An observable difference:
const { Linter } = require("eslint");
const linter = new Linter();
const results = linter.verify(`
/* eslint no-undef: 2 */
/* eslint-env browser */
window;
`);
console.log(results); // [], but there should be a no-undef lint message in flat config modeThe cause is the condition it uses to switch between modes:
Lines 1371 to 1372 in a9a17b3
There was a problem hiding this comment.
Hmmm, in that case adding a default value to the constructor won't fix the problem, because we are still checking for config. Probably need to revisit all of that logic.
|
I changed the condition in |
| assert.throws(() => { | ||
| linter.verify("foo", { rules: { "test-rule": "error" } }); | ||
| }, TypeError, "Could not find \"test-rule\" in plugin \"@\"."); | ||
|
|
There was a problem hiding this comment.
I believe this is a test file for the linter/rules.js module, which is only used in eslintrc mode so it might make more sense to keep the tests in eslintrc mode. However, I'm not sure why these particular tests were in this file since they relate to functionalities implemented in the Linter class, so seems best to revisit this at some later point.
* main: docs: Migrate to v9.0.0 (eslint#17905) docs: Switch to flat config by default (eslint#17840) docs: Update Create a Plugin for flat config (eslint#17826) feat!: add two more cases to `no-implicit-coercion` (eslint#17832) docs: Switch shareable config docs to use flat config (eslint#17827) chore: remove creating an unused instance of Linter in tests (eslint#17902) feat!: Switch Linter to flat config by default (eslint#17851)
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Made flat config mode the default for
Linterand updated associated code.Refs #13481
Is there anything you'd like reviewers to focus on?