Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rename FlatESLint to ESLint #17914

Merged
merged 3 commits into from Dec 29, 2023
Merged

feat!: Rename FlatESLint to ESLint #17914

merged 3 commits into from Dec 29, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Dec 28, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  1. Renamed ESLint to LegacyESLint
  2. Renamed FlatESLint to ESLint
  3. Updated the related tests
  4. Updated the related docs
  5. Updated the migration guide

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner December 28, 2023 22:22
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Dec 28, 2023
Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 8f12cae
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658eac425c56d50008859081
😎 Deploy Preview https://deploy-preview-17914--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I found a few more things that should be updated in docs, tests, and comments, but since this PR could easily run into merge conflicts, I'm going to merge it now and prepare a follow-up PR.

@mdjermanovic mdjermanovic merged commit cadfbcd into main Dec 29, 2023
25 of 26 checks passed
@mdjermanovic mdjermanovic deleted the flat-eslint-rename branch December 29, 2023 12:31
@mdjermanovic mdjermanovic mentioned this pull request Dec 29, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change is backwards-incompatible feature This change adds a new feature to ESLint
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants