New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependency glob to v10 #17917
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Converted to a draft because there are tests failing on Windows. |
|
||
// determine which files to check | ||
const filenames = (await Promise.all(patterns.map(pattern => globAsync(pattern, { nonull: true })))).flat(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nonull
is no longer supported.
// Remove OS-dependent path except base name. | ||
const normalizedStderr = | ||
// eslint-disable-next-line no-control-regex -- escaping control character | ||
stderr.replace(/(?<=\x1B\[4m).*(?=bad-examples\.md)/u, ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Windows, glob 10 now returns backslash-separated paths.
Tests are passing on Windows now. All Makefile tasks seem to work as usual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Leaving it open for others to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for digging into this @fasttime!
This PR contains the following updates:
^7.1.6
->^10.0.0
glob
is only used during build in Makefile.js and tools\check-rule-examples.js. The current version 10.3.0 supports all Node.js versions supported by ESLint 9: https://github.com/isaacs/node-glob/blob/v10.3.0/package.json#L96.The main differences from glob v7 are:
posix: true
).nonull
(https://github.com/isaacs/node-glob/blob/main/changelog.md#options-changes).Release Notes
isaacs/node-glob (glob)
v10.3.10
Compare Source
v10.3.9
Compare Source
v10.3.8
Compare Source
v10.3.7
Compare Source
v10.3.6
Compare Source
v10.3.5
Compare Source
v10.3.4
Compare Source
v10.3.3
Compare Source
v10.3.2
Compare Source
v10.3.1
Compare Source
v10.3.0
Compare Source
--default -p
flag to provide a default patternv10.2.7
Compare Source
v10.2.6
Compare Source
v10.2.5
Compare Source
v10.2.4
Compare Source
v10.2.3
Compare Source
v10.2.2
Compare Source
v10.2.1
Compare Source
v10.2.0
Compare Source
v10.1.0
Compare Source
'.'
instead of the empty string''
when the currentworking directory is returned as a match.
posix: true
option to return/
delimited paths, even onWindows.
v10.0.0
Compare Source
v9.3.5
Compare Source
v9.3.4
Compare Source
v9.3.3
Compare Source
nested extglob patterns.
v9.3.2
Compare Source
v9.3.1
Compare Source
v9.3.0
Compare Source
v9.2.1
Compare Source
v9.2.0
Compare Source
v9.1.2
Compare Source
v9.1.1
Compare Source
v9.1.0
Compare Source
v9.0.2
Compare Source
v9.0.1
Compare Source
v9.0.0
Compare Source
v8.1.0
Compare Source
v8.0.3
Compare Source
v8.0.2
Compare Source
v8.0.1
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.