Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use --force flag when installing eslint #17921

Merged
merged 1 commit into from Dec 29, 2023
Merged

ci: use --force flag when installing eslint #17921

merged 1 commit into from Dec 29, 2023

Conversation

mdjermanovic
Copy link
Member

Temporary solution for prerelease versions

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Prerelease versions of eslint will likely need to be installed using npm install --force, because some of the dependencies and dev dependencies have eslint as a peer dependency, and prereleases most likely won't satisfy those range constraints.

I prepared this so that we can quickly fix the CI after today's v9.0.0-alpha.0 release. Do not merge yet.

What changes did you make? (Give an overview)

Updated ci workflows to use the --force flag when installing eslint.

Is there anything you'd like reviewers to focus on?

Did I miss some places?

Temporary solution for prerelease versions
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Dec 29, 2023
Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 87bad96
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658f05cde8a9bd0008f5fa1a

@mdjermanovic mdjermanovic marked this pull request as ready for review December 29, 2023 23:50
@mdjermanovic mdjermanovic requested a review from a team as a code owner December 29, 2023 23:50
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 903ee60 into main Dec 29, 2023
17 checks passed
@nzakas nzakas deleted the ci-force-install branch December 29, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This change relates to ESLint's build process
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants