Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not use --force flag to install dependencies #18284

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Apr 7, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Update the build process

What changes did you make? (Give an overview)

Updated CI workflows and Netlify build to not use the --force flag when running npm install.

The --force flag was added in #17921 to allow installing prerealeses. Not that v9.0.0 final has been released, the flag should be no longer needed.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Apr 7, 2024
Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 7aa05a7
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6612820e3b0adc0008c6a687
😎 Deploy Preview https://deploy-preview-18284--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime marked this pull request as ready for review April 7, 2024 12:57
@fasttime fasttime requested a review from a team as a code owner April 7, 2024 12:57
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 1fa6622 into main Apr 8, 2024
18 of 19 checks passed
@snitin315 snitin315 deleted the no-force-install branch April 8, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This change relates to ESLint's build process github actions
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants