Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"generator-star" rule should support "middle" position #1808

Closed
feross opened this issue Feb 9, 2015 · 4 comments
Closed

"generator-star" rule should support "middle" position #1808

feross opened this issue Feb 9, 2015 · 4 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@feross
Copy link
Contributor

feross commented Feb 9, 2015

Should be possible to enforce a "middle" start position:

function * bazooka () {

}

cc @xjamundx

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules labels Feb 9, 2015
@xjamundx
Copy link
Contributor

Would this be acceptable as well?

function *      bazooka () {}

Would you be able to specify ["middle", 1] with 1 being the number of spaces on each side? Does it need to be even?

@nzakas
Copy link
Member

nzakas commented Feb 10, 2015

no-multi-spaces will pick up excess spaces, so I'd say just make sure there's whitespace on either side.

@xjamundx
Copy link
Contributor

I'll work on this in a bit yeah. Around 1 week.

@nzakas
Copy link
Member

nzakas commented Feb 18, 2015

Thanks!

xjamundx pushed a commit to xjamundx/eslint that referenced this issue Feb 27, 2015
@nzakas nzakas closed this as completed in 8bd773b Mar 3, 2015
nzakas added a commit that referenced this issue Mar 3, 2015
New: generator-star middle option (fixes #1808)
feross added a commit to standard/standard that referenced this issue Mar 9, 2015
feross added a commit to standard/standard that referenced this issue Mar 12, 2015
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

3 participants