Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export base config from eslint-config-eslint #18119

Merged
merged 1 commit into from Feb 14, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs eslint/eslint.org#512 (comment)

Adds base export in the eslint-config-eslint package.

Configs exported from the main and cjs entry points are intended for files that run in Node.js, and therefore cannot be readily used for files that don't run in Node.js, like browser scripts or modules that will be bundled for use in browsers, as we have in the eslint/eslint.org project.

What changes did you make? (Give an overview)

Added the new export in package.json, and updated README with an example of when and how to use it.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 14, 2024
@mdjermanovic mdjermanovic requested a review from a team as a code owner February 14, 2024 12:16
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Feb 14, 2024
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 1745460
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65ccaf1448bec70008fe90d7
😎 Deploy Preview https://deploy-preview-18119--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 1a65d3e into main Feb 14, 2024
17 checks passed
@nzakas nzakas deleted the eslintconfigeslint-export-base branch February 14, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants