chore: remove unused tools: rule-types.json, update-rule-types.js #18125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
requested changes
Feb 18, 2024
Makefile.js
Outdated
| @@ -670,168 +668,6 @@ target.webpack = function(mode = "none") { | |||
| exec(`${getBinFile("webpack")} --mode=${mode} --output-path=${BUILD_DIR}`); | |||
| }; | |||
|
|
|||
| target.checkRuleFiles = function() { | |||
There was a problem hiding this comment.
We can remove checks related to tools/rule-types.json, but all other checks should remain.
mdjermanovic
added
the
accepted
|
Browser test is failing for reasons unrelated to this PR, and is already failing in the same way on the main branch, so I think it's safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Internal cleanup
What changes did you make? (Give an overview)
Fixes #18121.
Removes two unused files as noted in the issue.
Also removes themarkeddependency, as it appears nothing is using it now.Is there anything you'd like reviewers to focus on?
I don't have a lot of context on these older internal utilities.