Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flat config name on ignores object #18258

Merged
merged 1 commit into from Apr 2, 2024
Merged

fix: flat config name on ignores object #18258

merged 1 commit into from Apr 2, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 2, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Dependency upgrade

What changes did you make? (Give an overview)

Upgraded @humanwhocodes/config-array

This fixes a bug where a config object containing name and ignores won't honor the ignores.

refs humanwhocodes/config-array#131

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner April 2, 2024 17:55
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 64e6223
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/660c4683fdd1e300084a05e4

@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 2, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I think there's one detail missed in the fix, but it doesn't make a functional difference. I'll submit a PR to config-array.

@mdjermanovic mdjermanovic merged commit a129acb into main Apr 2, 2024
18 checks passed
@mdjermanovic mdjermanovic deleted the config-name-fix branch April 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants