Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore name field for global ignores #131

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: ignore name field for global ignores #131

merged 1 commit into from
Apr 2, 2024

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Apr 2, 2024

Current ignores will no longer apply when name is specified - which means we can't have name field to describe configs for global ignores

nzakas
nzakas approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nzakas nzakas merged commit 286f489 into humanwhocodes:main Apr 2, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Merged
@nzakas nzakas mentioned this pull request Apr 2, 2024
Merged
1 task
@mdjermanovic mdjermanovic mentioned this pull request Apr 2, 2024
Merged
@aladdin-add aladdin-add mentioned this pull request May 29, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antfu @nzakas