Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename space-before-function-parentheses -> space-before-function-parens #2028

Closed
nzakas opened this issue Mar 14, 2015 · 1 comment
Closed

Rename space-before-function-parentheses -> space-before-function-parens #2028

nzakas opened this issue Mar 14, 2015 · 1 comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@nzakas
Copy link
Member

nzakas commented Mar 14, 2015

Someone pointed out that this is the only rule where we force users to spell "parentheses" whereas every other rule we simply use "parens". Probably best to be consistent going into v1.0.0.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@nzakas nzakas added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 14, 2015
@btmills
Copy link
Member

btmills commented Mar 15, 2015

Working on this.

btmills added a commit that referenced this issue Mar 15, 2015
@btmills
Update: rename space-before-function-parentheses to space-before-func…
0e45118 
…iton-parens (fixes (#2028)
btmills added a commit that referenced this issue Mar 15, 2015
@btmills
Update: Rule names should use parens (fixes #2028)
50560a3 
Renames space-before-function-parentheses to
space-before-function-parens
btmills added a commit that referenced this issue Mar 15, 2015
@btmills
Update: Rule names should use parens (fixes #2028)
ccb4a96 
Renames space-before-function-parentheses to
space-before-function-parens
btmills added a commit that referenced this issue Mar 15, 2015
@btmills
Update: Rule names should use parens (fixes #2028)
acd0802 
Renames space-before-function-parentheses to
space-before-function-parens
btmills added a commit that referenced this issue Mar 17, 2015
@btmills
New: space-before-function-paren rule (fixes #2028)
597e7dd
nzakas added a commit that referenced this issue Mar 18, 2015
@nzakas
Merge pull request #2050 from eslint/issue2028
f0c17f3 
New: space-before-function-paren rule (fixes #2028)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nzakas @btmills