no-multi-spaces conflicts with smart-tabs

[bluesmoon]

If I have "no-mixed-spaces-and-tabs":[2, "smart-tabs"], then no-multi-spaces should not throw an error/warning for lines that use smart-tabs.

test case, try with the following code:

/*eslint no-mixed-spaces-and-tabs:[2, "smart-tabs"], no-multi-spaces:2 */
var i=10,
    j=20;

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[nzakas]

What version of ESLint are you using? I don't see any errors with this code.

In the future, please also include the errors you're seeing on the console when reporting an issue. It really helps us triage.

[bluesmoon]

0.17.0

   441:7   warning  Multiple spaces found before 'i'                  no-multi-spaces
   442:7   warning  Multiple spaces found before 'gotcookies'         no-multi-spaces
   443:7   warning  Multiple spaces found before 'cookies'            no-multi-spaces

code:

            var cookies_a,
                i, l, kv,
                gotcookies=false,
                cookies={};

(3 tabs, and then 4 spaces to align variable names)

/*eslint-env browser*/
/*global BOOMR:true, BOOMR_start:true, BOOMR_lstart:true, console:false*/
/*eslint no-mixed-spaces-and-tabs:[2, true], console:0, camelcase:0, strict:0, quotes:[2, "double", "avoid-escape"], new-cap:0*/
/*eslint space-infix-ops:0, no-console:0, no-delete-var:0, no-space-before-semi:0, no-multi-spaces:1, space-unary-ops: 0, key-spacing: 0, dot-notation: [2, {"allowKeywords": true }]*/

[nzakas]

Ah okay, GitHub was converting those to spaces.

Yeah, we can probably just ignore spaces that are in indent position.

[mourner]

Came here to open the same issue. 👍

[gyandeeps]

@nzakas @ilyavolodin Based on the discussion, I think a decision has been made but the labels are not yet updated.

[nzakas]

Yup, thanks!

[message]

+1

[ohshhh]

+1

[nzakas]

@message @tape88 thanks for commenting. This issue is marked as "accepted", so it's just waiting for someone to volunteer to work on it.

[satya164]

Have the same issue. Anyone working on it yet?

[IanVS]

@satya164 It's all yours if you want it. Looks like some tweaking is needed in: https://github.com/eslint/eslint/blob/master/lib/rules/no-multi-spaces.js#L73

[satya164]

@IanVS I can work on it, can you point me to documentation for writing rules?

[IanVS]

Yep, rule development docs are at: http://eslint.org/docs/developer-guide/working-with-rules

I would suggest to create a test case first which fails, and then update the regex I linked to so that the test passes. Feel free to hop in the Gitter room if you need more guidance.

[IanVS]

@satya164, do you still plan to work on this? I verified it is still an issue in 1.8.0.

[oh-ren]

+1 :) (Still an issue in 1.9.0)

Btw, although somewhat a different discussion, when using smart-tabs, I also have to set VariableDeclarator to 0 in my indent options, otherwise I get complaints from that :)
It's my feeling when using smart-tabs, this should be handled in a smart way too. Setting to 0 is of course undesirable, as the linter then also just accepts no 'smart' indenting/alignment at all...

[edit] It could make sense / clear things up to house all this under the indent rule and remove the no-mixed-spaces-and-tabs rule?

[nzakas]

@oh-ren please open a separate issue for that discussion.

[oh-ren]

@nzakas Will do, was already thinking about that myself as well.

[afahim]

I've taken a stab at this, let me know if you have any comments / suggestions.