Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new-cap rule could accept "Error" as an exception #2098

Closed
mickaeltr opened this issue Mar 18, 2015 · 2 comments
Closed

new-cap rule could accept "Error" as an exception #2098

mickaeltr opened this issue Mar 18, 2015 · 2 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@mickaeltr
Copy link

Hello,

Currently, the "new-cap" rule has a property "capIsNewExceptions" which defaults to the following value:
["Object", "Function", "Number", "String", "Boolean", "Date", "Array", "Symbol", "RegExp"]

What do you think about adding "Error" to this list?

Cheers
@michaelficarra
Copy link
Member

👍

@nzakas nzakas added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 18, 2015
@nzakas
Copy link
Member

nzakas commented Mar 18, 2015

Sounds good.

@mickaeltr mickaeltr mentioned this issue Mar 18, 2015
Closed
@nzakas nzakas closed this as completed in d38d438 Mar 18, 2015
nzakas added a commit that referenced this issue Mar 18, 2015
@nzakas
Merge pull request #2106 from mickaeltr/add-error-to-new-cap-rule-exc…
7bdb3d8 
…eptions

Fix: Add "Error" to the "new-cap" rule exceptions (fixes #2098)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @michaelficarra @mickaeltr