-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment before comma trigger comma-spacing error #2408
Comments
I don't think this is related to 1457, since that was different. |
Related to #2211. |
Is this also related to #1659? |
Slightly, but not directly. |
Also been hit by this with code such as this: [
[0x61, 0x7A] /*a-z*/,
[0x41, 0x5A] /*A-Z*/,
0x2E /*'.'*/, 0x2B /*'+'*/, 0x2D /*'-'*/
] Removing the space before the comment doesn't seem to help. I think |
Certain cases with comments inside arrays or object literals fail to pass eslint's comma-spacing rule. This change sets the comma-spacing rule to the 'warn' level. Once eslint/eslint#2408 is resolved and released, this rule should be set back to 'error' level. PR-URL: #1672 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Fix: Allow comment before comma for comma-spacing rule (fixes #2408)
Certain cases with comments inside arrays or object literals fail to pass eslint's comma-spacing rule. This change sets the comma-spacing rule to the 'warn' level. Once eslint/eslint#2408 is resolved and released, this rule should be set back to 'error' level. PR-URL: nodejs#1672 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
The rule was disabled because of an eslint bug which is now resolved. All code in lib was already conforming and only test code needed a few changes to make the linter happy with this rule enabled. Ref: eslint/eslint#2408
The rule was disabled because of an eslint bug which is now resolved. All code in lib was already conforming and only test code needed a few changes to make the linter happy with this rule enabled. Ref: eslint/eslint#2408 PR-URL: #2072 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alex Kocharin <alex@kocharin.ru>
The rule was disabled because of an eslint bug which is now resolved. All code in lib was already conforming and only test code needed a few changes to make the linter happy with this rule enabled. Ref: eslint/eslint#2408 PR-URL: nodejs#2072 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alex Kocharin <alex@kocharin.ru>
Use default setting on http://eslint.org/demo/
Codes:
Result:
i'm new here, not sure if this is a feature or bug. maybe related to #1457
The text was updated successfully, but these errors were encountered: