Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule no-undef breaks with spread operator on not declared object / require() call #3157

Closed
gre opened this issue Jul 24, 2015 · 3 comments
Closed
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@gre
Copy link

gre commented Jul 24, 2015

On current eslint@1.0.0-rc-2

/Users/gre/dev/projectseptember/modules/mobile/node_modules/eslint/lib/rules/no-undef.js:53
    return parent.type === "UnaryExpression" && parent.operator === "typeof";

with:

module.exports = {
  ...require("./something"),
  foo: require("./foo")
};

it also breaks with:

const c;
const a = {
  ...b, // b is not declared
  c
};
@eslintbot
Copy link

Thanks for the issue! We get a lot of issues, so this message is automatically posted to each one to help you check that you've included all of the information we need to help you.

Reporting a bug? Please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. The source code that caused the problem
  3. The configuration you're using (for the rule or your entire config file)
  4. The actual ESLint output complete with line numbers

Requesting a new rule? Please be sure to include:

  1. The use case for the rule - what is it trying to prevent or flag?
  2. Whether the rule is trying to prevent an error or is purely stylistic
  3. Why you believe this rule is generic enough to be included

Requesting a feature? Please be sure to include:

  1. The problem you want to solve (don't mention the solution)
  2. Your take on the correct solution to problem

Including this information in your issue helps us to triage it and get you a response as quickly as possible.

Thanks!

@gre gre changed the title Rule no-undef breaks with spread operator on object Rule no-undef breaks with spread operator on undefined object Jul 24, 2015
@gre gre changed the title Rule no-undef breaks with spread operator on undefined object Rule no-undef breaks with spread operator on not declared object / require() call Jul 24, 2015
@gyandeeps gyandeeps added the triage An ESLint team member will look at this issue soon label Jul 24, 2015
@mysticatea
Copy link
Member

Thank you for the report.

I can reproduce it.

@mysticatea mysticatea added bug ESLint is working incorrectly accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 24, 2015
@gyandeeps gyandeeps added the rule Relates to ESLint's core rules label Jul 24, 2015
@mysticatea
Copy link
Member

I will try to fix.

mysticatea added a commit to mysticatea/eslint that referenced this issue Jul 24, 2015
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

4 participants