Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all rules from http://jslinterrors.com/ as issues #32

Closed
nzakas opened this issue Jul 14, 2013 · 9 comments
Closed

Add all rules from http://jslinterrors.com/ as issues #32

nzakas opened this issue Jul 14, 2013 · 9 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion

Comments

@nzakas
Copy link
Member

nzakas commented Jul 14, 2013

The site http://jslinterrors.com/ has explanations of all JSLint/JSHint errors. We should be sure that there is an issue for each rule that we haven't yet implemented.

@jamesallardice
Copy link

Unfortunately, I don't yet have all JSLint/Hint errors listed on there. I'm working on it, but there's a fair few missing. However, there is a comprehensive list in the wiki for the repo: https://github.com/jamesallardice/jslint-error-explanations/wiki/List-of-pages-that-are-needed.

I'll gradually be updating that wiki page with a list of implemented ESLint errors too.

@nzakas
Copy link
Member Author

nzakas commented Jul 14, 2013

Even though incomplete, it's still a much better list than the one on the
JSHint site.

On Sun, Jul 14, 2013 at 2:05 PM, James Allardice
notifications@github.comwrote:

Unfortunately, I don't yet have all JSLint/Hint errors listed on there.
I'm working on it, but there's a fair few missing. However, there is a
comprehensive list in the wiki for the repo:
https://github.com/jamesallardice/jslint-error-explanations/wiki/List-of-pages-that-are-needed
.

I'll gradually be updating that wiki page with a list of implemented
ESLint errors too.


Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-20943787
.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@jamesallardice
Copy link

I would like to add proper support for ESLint to http://jslinterrors.com, which would require a browser-compatible build of the tool (as far as I can tell browserify won't cut it on its own, due to the way rules are required).

Do you have any plans for that? I'm more than happy to build one myself if not.

@nzakas
Copy link
Member Author

nzakas commented Jul 17, 2013

Yes, that's definitely on the roadmap. I was thinking of using browserify
to wrap eslint.js for use in browsers. If you'd like to take a stab, feel
free!

On Tue, Jul 16, 2013 at 8:15 AM, James Allardice
notifications@github.comwrote:

I would like to add proper support for ESLint to http://jslinterrors.com,
which would require a browser-compatible build of the tool (as far as I can
tell browserify won't cut it on its own, due to the way rules are
required).

Do you have any plans for that? I'm more than happy to build one myself if
not.


Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-21048946
.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@Bartvds
Copy link

Bartvds commented Jul 26, 2013

If you want to start adding custom builds you might want to setup a scalable build system that isnt just some shellscript. If you want to maximise comminity contributions itd have to work on al platforms with only a simple install from NPM and no odd external CLI tools. The currently popular system is grunt. It has plugins for every tool you ever want. Including browserify.

@jamesallardice
Copy link

@Bartvds Exactly. I've already started playing around with a Grunt script. I'll try and get something working over the weekend.

@nzakas
Copy link
Member Author

nzakas commented Jul 27, 2013

I'm not a fan of Grunt and so don't want to introduce it into the system (I know, it's the new hotness, but I really don't care for it). I don't mind having bash scripts, as Windows users can use Git Bash (as I do). I'm open to other options but please post ideas to #145 before building anything - I don't want to have you do a bunch of work that I may already be working on (build system has been on my list to investigate).

@jamesallardice
Copy link

@nzakas Ok, fair enough. Out of interest, what do you prefer in Jake over Grunt? To be honest I haven't used Jake much so can't really compare them.

@nzakas
Copy link
Member Author

nzakas commented Oct 5, 2013

Closing this because I think we have our act together on all fronts.

@nzakas nzakas closed this as completed Oct 5, 2013
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

No branches or pull requests

3 participants