Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: no-undef: ESLint no longer supports jshint/jslint environments #3616

Closed
IanVS opened this issue Sep 1, 2015 · 2 comments
Closed

Docs: no-undef: ESLint no longer supports jshint/jslint environments #3616

IanVS opened this issue Sep 1, 2015 · 2 comments
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation

Comments

@IanVS
Copy link
Member

IanVS commented Sep 1, 2015

The docs for no-undef talk about using /*jslint browser:true*/ and /*jshint node:true*/. I tried the example given, and it no longer works:

/*jshint node:true*/
/*eslint no-undef: 2*/

var fs = require("fs");
module.exports = function() {
    console.log(fs);
};

gives:

  4:10  error  "require" is not defined  no-undef
  5:1   error  "module" is not defined   no-undef
  6:5   error  "console" is not defined  no-undef

I think the docs for this rule should probably be updated to use /*eslint-env*/ instead, yes?

@IanVS IanVS added the triage An ESLint team member will look at this issue soon label Sep 1, 2015
@ilyavolodin
Copy link
Member

I think the docs should be update in any case. I think support of jshint and jslint comments were removed a long time ago (somebody correct me if I'm wrong, it's been a while).

@ilyavolodin ilyavolodin added bug ESLint is working incorrectly documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Sep 1, 2015
@IanVS IanVS self-assigned this Sep 1, 2015
IanVS pushed a commit that referenced this issue Sep 1, 2015
@nzakas
Copy link
Member

nzakas commented Sep 1, 2015

Yup

@IanVS IanVS closed this as completed in c07d7d6 Sep 2, 2015
nzakas added a commit that referenced this issue Sep 2, 2015
Docs: Use eslint-env in no-undef (fixes #3616)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Development

No branches or pull requests

3 participants