Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint repo does not have an .eslintignore file #3765

Closed
BYK opened this issue Sep 12, 2015 · 7 comments
Closed

ESLint repo does not have an .eslintignore file #3765

BYK opened this issue Sep 12, 2015 · 7 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint infrastructure Relates to the tools used in the ESLint development process

Comments

@BYK
Copy link
Member

BYK commented Sep 12, 2015

Ironically, our own repo doesn't have an .eslintignore file so running node bin/eslint.js . generates a lot of errors.
@eslintbot
Copy link

Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Sep 12, 2015
@nzakas
Copy link
Member

nzakas commented Sep 14, 2015

What errors are you talking about? After node_modules is ignored, what else should we be ignoring?

@BYK
Copy link
Member Author

BYK commented Sep 14, 2015

Fixtures, coverage etc.

@nzakas
Copy link
Member

nzakas commented Sep 14, 2015

We're already ignoring those, unless I'm missing something.

@nzakas
Copy link
Member

nzakas commented Sep 14, 2015

Oh, I think I see what you mean. You want to do eslint .?

@BYK
Copy link
Member Author

BYK commented Sep 15, 2015

Oh, I think I see what you mean. You want to do eslint .?

Yup, exactly :)

@nzakas nzakas added enhancement This change enhances an existing feature of ESLint infrastructure Relates to the tools used in the ESLint development process accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Sep 15, 2015
@nzakas
Copy link
Member

nzakas commented Sep 15, 2015

Probably a good idea to dogfood ignores functionality. Let's do it.

gyandeeps added a commit that referenced this issue Oct 2, 2015
@gyandeeps
Build: Add .eslintignore file for the project (fixes #3765)
a10a319
nzakas added a commit that referenced this issue Oct 3, 2015
@nzakas
Merge pull request #4022 from eslint/issue3765
5d3e58c 
Build: Add `.eslintignore` file for the project (fixes #3765)
gyandeeps added a commit that referenced this issue Oct 6, 2015
@gyandeeps
Fix: Performance perf to not ignore jshint file (refs #3765)
6e4e663
gyandeeps added a commit that referenced this issue Oct 6, 2015
@gyandeeps
Build: Performance perf to not ignore jshint file (refs #3765)
c5d46a4
nzakas added a commit that referenced this issue Oct 6, 2015
@nzakas
Merge pull request #4063 from eslint/perfFix
c4487da 
Build: Performance perf to not ignore jshint file (refs #3765)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @BYK @eslintbot