Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSX code fences #4020

Closed
nzakas opened this issue Oct 2, 2015 · 6 comments
Closed

Remove JSX code fences #4020

nzakas opened this issue Oct 2, 2015 · 6 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation

Comments

@nzakas
Copy link
Member

nzakas commented Oct 2, 2015

The jsx-quotes rule documentation has code fences in it using jsx. This is an invalid code fence and needs to be changed as it breaks the Jekyll site generation. Maybe it should be html instead?

@lo1tuma

@nzakas nzakas added bug ESLint is working incorrectly documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Oct 2, 2015
@michaelficarra
Copy link
Member

If Jekyll doesn't support it, don't highlight it. It's certainly not HTML.

@lo1tuma
Copy link
Member

lo1tuma commented Oct 3, 2015

I agree with @michaelficarra

@alberto
Copy link
Member

alberto commented Oct 3, 2015

jekyll doesn't support it out of the box. I couldn't even find a jsx lexer.
even if there was one, I don't think you can make it work on github pages
El 03/10/2015 16:56, "Michael Ficarra" notifications@github.com escribió:

If Jekyll doesn't support it, don't highlight it. It's certainly not HTML.


Reply to this email directly or view it on GitHub
#4020 (comment).

@btmills
Copy link
Member

btmills commented Oct 3, 2015

Linguist detects JSX. I'd say keep it.

@nzakas
Copy link
Member Author

nzakas commented Oct 3, 2015

I think I'm not being clear: this broke the site, keeping it is not an option. I had to manually go in and remove it to get the site to generate.

The actual examples using it contained only HTML. I actually don't care if it's tagged as HTML or not, but it can't be tagged as JSX without breaking site generation.

@btmills
Copy link
Member

btmills commented Oct 3, 2015

Working on this. Going with HTML so we at least have some highlighting unless someone objects.

@btmills btmills closed this as completed in 82ae7ec Oct 3, 2015
ilyavolodin added a commit that referenced this issue Oct 3, 2015
Docs: Re-tag JSX code fences (fixes #4020)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Development

No branches or pull requests

5 participants