Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-cond-assign giving error on intentional assignment in for loop #4023

Closed
carlbennettnz opened this issue Oct 2, 2015 · 5 comments
Closed
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@carlbennettnz
Copy link

/* eslint no-cond-assign: 2 */
for (var i = 0, item; (item = arr[i]); i++) { }

Even with the no-cond-assign set to the default except-parens rule, this still fails. Intentional?

Output:

  2:1   error  Expected a conditional expression and instead saw an assignment  no-cond-assign
@eslintbot
Copy link

Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Oct 2, 2015
@ilyavolodin
Copy link
Member

Can you provide version of ESLint you are using and your config file please?

@carlbennettnz
Copy link
Author

v1.6.0

No config except for that one inline rule.

@ilyavolodin
Copy link
Member

Based on the code of the rule, it looks like this is a bug, and rule should allow it. Also error message is pointing to the wrong location (for keyword instead of the test node).

@ilyavolodin ilyavolodin added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 3, 2015
@mysticatea
Copy link
Member

I will try to fix this.

@mysticatea mysticatea self-assigned this Oct 6, 2015
mysticatea added a commit to mysticatea/eslint that referenced this issue Oct 6, 2015
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

4 participants