Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename no-magic-number to no-magic-numbers #4053

Closed
nzakas opened this issue Oct 5, 2015 · 0 comments · Fixed by #4055
Closed

Rename no-magic-number to no-magic-numbers #4053

nzakas opened this issue Oct 5, 2015 · 0 comments · Fixed by #4055
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint good first issue Good for people who haven't worked on ESLint before rule Relates to ESLint's core rules

Comments

@nzakas
Copy link
Member

nzakas commented Oct 5, 2015

We generally use the plural form of words in rules because we are flagging all instances, not one. As such, no-magic-number should be renamed no-magic-numbers.
@nzakas nzakas added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Oct 5, 2015
@nzakas nzakas mentioned this issue Oct 5, 2015
Merged
@nzakas nzakas added the good first issue Good for people who haven't worked on ESLint before label Oct 5, 2015
kombucha added a commit to kombucha/eslint that referenced this issue Oct 5, 2015
@kombucha
Fix: renamed no-magic-number to no-magic-numbers (fixes eslint#4053)
7a8516e
@kombucha kombucha mentioned this issue Oct 5, 2015
Merged
ilyavolodin added a commit that referenced this issue Oct 5, 2015
@ilyavolodin
Merge pull request #4055 from kombucha/fix-no-magic-number-naming
6e49180 
Fix: renamed no-magic-number to no-magic-numbers (fixes #4053)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint good first issue Good for people who haven't worked on ESLint before rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: renamed no-magic-number to no-magic-numbers (fixes #4053) kombucha/eslint
1 participant
@nzakas